Handle a bunch of the actually helpful clang-tidy issues

[ckormanyos]

There are quite a few actually helpful clang tidy issues. Many of these can be seen when scrolling through this log.

Yet these are quite easy to handle.

The purpose of this issue is to handle meaningful clang-tidy messages in a minimally-invasive way.

[ckormanyos]

Hi Matt (@mborland) in the spirit of moving forward, I plan to remove:

• remove: llvm-else-after-return
• remove readability-else-after-return

due to lack of tangible value. These are getting in the way of meaningful messages.

Is this OK for you?

[mborland]

Hi Matt (@mborland) in the spirit of moving forward, I plan to remove:

• remove: llvm-else-after-return

• remove readability-else-after-return

due to lack of tangible value. These are getting in the way of meaningful messages.

Is this OK for you?

That's good with me. I find that sonarlint gives fewer messages than clang tidy but they seem to be higher quality.

[ckormanyos]

Basically all the activated/removed rules can be found here.

Line 45 activates everything via the *. Then subsequently specific rules or wildcard rule-sets are disabled with the minus sign.