Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add_library() isn't aware of h-file location like add_executable() #537

Open
greenduck opened this issue Feb 21, 2024 · 1 comment
Open

Comments

@greenduck
Copy link

If I use add_executable() it automatically "knows" where to find every h-file.
However, add_library() with the same source files (except for main.cpp) requires adding target_include_directories() with the locations of all the h-files.
Shouldn't CPM find the h-files "for everyone" ?

@Radagan
Copy link

Radagan commented Jun 20, 2024

I'm having a similar problem with an executable using CPM 0.40.0 with our own libraries hosted on GitLab. Additionally, the libraries are not being built for some reason, so linking fails.

For example:

CPMAddPackage("gh:fmtlib/fmt#10.2.1")

...works fine, but this:

CPMAddPackage(
    NAME common
    VERSION 1.0.9
    GIT_REPOSITORY [email protected]
)

requires this to resolve the includes:

target_include_directories(myapp PUBLIC
    src
    $<BUILD_INTERFACE:${common_SOURCE_DIR}/include>
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants