Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add IIIF v2 support #11

Open
cpietsch opened this issue Jun 8, 2023 · 2 comments
Open

add IIIF v2 support #11

cpietsch opened this issue Jun 8, 2023 · 2 comments

Comments

@cpietsch
Copy link
Owner

cpietsch commented Jun 8, 2023

should be possible
@flicksolutions
Copy link

Hi Christopher
Can you point in any direction what would need to change to be able to support v2.1? What did you find out so far?
We might be able to contribute to this!

Thanks for your awesome tool!

@cpietsch
Copy link
Owner Author

Hi Sebastian,
that should be here: https://github.com/cpietsch/vikus-IIIF-generator/blob/main/scripts/manifestCrawler.py#L54 and here https://github.com/cpietsch/vikus-IIIF-generator/blob/main/scripts/manifest.py#L59
Basically everywhere where a if ...version == 2: is. It is a bit hardcoded like that and maybe a cleaner refactoring would be nice.
You can test it by running python manifest.py directly and see if it works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cpietsch @flicksolutions