Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Implement multiple settle requests in autopilot #2998

Closed
sunce86 opened this issue Sep 16, 2024 · 0 comments · Fixed by #2996
Closed

feat: Implement multiple settle requests in autopilot #2998

sunce86 opened this issue Sep 16, 2024 · 0 comments · Fixed by #2996
Assignees
@sunce86
Labels
E:6.2 Time to Happy Moo See https://github.com/cowprotocol/pm/issues/77 for details

Comments

@sunce86
Copy link
Contributor

sunce86 commented Sep 16, 2024 •
edited
Loading

Problem

With multiple winners per Auction, autopilot needs to support sending multiple /settle requests to solvers and waiting for transactions to be mined.

Note

Also address some code review comments from Martin #2976 (comment)

Done ☝️
@sunce86 sunce86 added the E:6.2 Time to Happy Moo See https://github.com/cowprotocol/pm/issues/77 for details label Sep 16, 2024
This was referenced Sep 16, 2024
Closed
Merged
sunce86 added a commit that referenced this issue Sep 26, 2024
@sunce86
Fetch solver that created settlement transaction (#3003)
9e488c3 
# Description
A preparation to implement
#2998 which will require
sending multiple settle requests to drivers, and waiting for multiple
settlement transactions.

In order to match settle requests with settlement transactions, we need
`solver` that created the settlement transaction.

# Changes
<!-- List of detailed changes (how the change is accomplished) -->

- [ ] Fetch solver from settlement event and use it to make sure it's
the same as the driver reported solver address.

## How to test
Existing e2e tests.
@sunce86 sunce86 mentioned this issue Sep 27, 2024
Merged
3 tasks
@sunce86 sunce86 self-assigned this Oct 3, 2024
@sunce86 sunce86 closed this as completed in 416c767 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sunce86 sunce86

Labels
E:6.2 Time to Happy Moo See https://github.com/cowprotocol/pm/issues/77 for details
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Multiple winners in autopilot cowprotocol/services
1 participant
@sunce86