Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Multiple winners in autopilot competition #2995

Closed
sunce86 opened this issue Sep 16, 2024 · 0 comments · Fixed by #2996
Closed

feat: Multiple winners in autopilot competition #2995

sunce86 opened this issue Sep 16, 2024 · 0 comments · Fixed by #2996
Assignees
Labels
E:6.2 Time to Happy Moo See https://github.com/cowprotocol/pm/issues/77 for details

Comments

@sunce86
Copy link
Contributor

sunce86 commented Sep 16, 2024

Problem

Related to #2830 (comment)

This issue captures work around adjusting the competition in autopilot and how we do scoring, ranking and choosing a winner.

Right now, ranking is done first, and the solution with the highest score wins the competition, and it's allowed to settle the solution.
Going forward, we want to enable multiple solutions to win the auction and be allowed to settle the solution at the same time. There are a few constraints here:

  1. A single solver can win only once per Auction. This means no multiple /settle calls will be issues to the same solver per Auction.
  2. Once a global winner is chosen, a secondary winner can only contain trades that are not using any token from the global solution. So, no common tokens are allowed between multiple winners. This is to keep the UCP rule and to minimize the chance of collision and racing to settle common tokens between solvers.

Suggested solution

Adjust the competition logic in autopilot. Beware the scope of this task is to choose the winners according to the rules and that is all. Saving of competition data and issuing settle calls are captured in other tasks.

Also, save fee policies for all proposed solutions, not just for the winning solution like we do now. (already tackled with #2999)

@sunce86 sunce86 added the E:6.2 Time to Happy Moo See https://github.com/cowprotocol/pm/issues/77 for details label Sep 16, 2024
@sunce86 sunce86 self-assigned this Oct 3, 2024
@sunce86 sunce86 closed this as completed in 416c767 Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:6.2 Time to Happy Moo See https://github.com/cowprotocol/pm/issues/77 for details
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant