Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Include the quote in the full order #2981

Open
m-lord-renkse opened this issue Sep 12, 2024 · 1 comment
Open

chore: Include the quote in the full order #2981

m-lord-renkse opened this issue Sep 12, 2024 · 1 comment
Labels
stale

Comments

@m-lord-renkse
Copy link
Contributor

Background

This PR implemented a SQL query to fetch the full order with the quote in one roundtrip. Take advantage of that to include the quote in the full order.

Details

Remove the struct OrderWithQuote and replace it with FullOrder. FullOrder now should include the quote too.

Acceptance criteria

The full order shall contain the quote.
@m-lord-renkse m-lord-renkse mentioned this issue Sep 12, 2024
Merged
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@m-lord-renkse