Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update database::settlements::get_hash_by_auction_id() #2975

Closed
sunce86 opened this issue Sep 12, 2024 · 0 comments · Fixed by #2976
Closed

feat: Update database::settlements::get_hash_by_auction_id() #2975

sunce86 opened this issue Sep 12, 2024 · 0 comments · Fixed by #2976
Labels
E:6.2 Time to Happy Moo See https://github.com/cowprotocol/pm/issues/77 for details

Comments

@sunce86
Copy link
Contributor

sunce86 commented Sep 12, 2024

Problem

Currently the function tries to find a single transaction hash for an auction, instead of multiple of them.

Suggested solution

Refactor the function and dependent code to potentially return a Vec of transaction hashes.
@sunce86 sunce86 added the E:6.2 Time to Happy Moo See https://github.com/cowprotocol/pm/issues/77 for details label Sep 12, 2024
This was referenced Sep 12, 2024
Closed
Merged
sunce86 added a commit that referenced this issue Sep 12, 2024
@sunce86
Get_hashes_by_auction_id implementation for multiple settlements (#2976)
e8a5c7a 
# Description
Fixes #2975

# Changes
<!-- List of detailed changes (how the change is accomplished) -->

- [ ] ...
- [ ] ...

## How to test
<!--- Include details of how to test your changes, including any
pre-requisites. If no unit tests are included, please explain why and
how to test manually
1.
2.
3.
-->

<!--
## Related Issues

Fixes #
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E:6.2 Time to Happy Moo See https://github.com/cowprotocol/pm/issues/77 for details
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Get_hashes_by_auction_id implementation for multiple settlements cowprotocol/services
1 participant
@sunce86