-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autopilot to use score
based on domain::Settlement
instead of trusting the driver.
#2720
Comments
This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed. |
This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed. |
This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed. |
I worked on this but eventually got blocked by actually using new Auction table and removing the duplicated struct in https://github.com/cowprotocol/services/blob/main/crates/autopilot/src/domain/settlement/auction.rs Actually using new Auction object is still in progress here https://github.com/cowprotocol/services/tree/use-new-auction-table so will first create a PR for that. |
Instead of using driver provided
score
to compare the solutions, autopilot should builddomain::Settlement
from each solution and callscore
function and use that to compare solutions.Dependent on #2719 and #2718
The text was updated successfully, but these errors were encountered: