Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autopilot to use score based on domain::Settlement instead of trusting the driver. #2720

Open
Tracked by #2716
sunce86 opened this issue May 11, 2024 · 4 comments
Open
Tracked by #2716
Assignees
Labels
E:7.1 Ext. solvers operating driver See https://github.com/cowprotocol/pm/issues/57 for details

Comments

@sunce86
Copy link
Contributor

sunce86 commented May 11, 2024

Instead of using driver provided score to compare the solutions, autopilot should build domain::Settlement from each solution and call score function and use that to compare solutions.

Dependent on #2719 and #2718

@sunce86 sunce86 self-assigned this May 11, 2024
@sunce86 sunce86 added the E:7.1 Ext. solvers operating driver See https://github.com/cowprotocol/pm/issues/57 for details label May 11, 2024
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Sep 24, 2024
@sunce86 sunce86 removed the stale label Sep 24, 2024
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@sunce86
Copy link
Contributor Author

sunce86 commented Dec 1, 2024

I worked on this but eventually got blocked by actually using new Auction table and removing the duplicated struct in https://github.com/cowprotocol/services/blob/main/crates/autopilot/src/domain/settlement/auction.rs

Actually using new Auction object is still in progress here https://github.com/cowprotocol/services/tree/use-new-auction-table so will first create a PR for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E:7.1 Ext. solvers operating driver See https://github.com/cowprotocol/pm/issues/57 for details
Projects
None yet
Development

No branches or pull requests

2 participants