Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: Use TokenPair as a key in the 0x liquidity cache #2654

Closed
squadgazzz opened this issue Apr 23, 2024 · 2 comments
Closed

chore: Use TokenPair as a key in the 0x liquidity cache #2654

squadgazzz opened this issue Apr 23, 2024 · 2 comments

Comments

@squadgazzz
Copy link
Contributor

Background

0x liquidity cache is represented by a map with (H160, 160) key type which allows to identify direction(sell or buy). There is a proposal to replace it with TokenPair, which is sorted inside. A bit more context can be found in this thread.

Details

We should make sure that changing the logic won't harm any other part of the protocol.
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Jun 23, 2024
@squadgazzz squadgazzz removed the stale label Jun 24, 2024
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Aug 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@squadgazzz