Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Dex solvers to return fee in sell token for quotes #2601

Open
sunce86 opened this issue Apr 8, 2024 · 3 comments
Open

feat: Dex solvers to return fee in sell token for quotes #2601

sunce86 opened this issue Apr 8, 2024 · 3 comments

Comments

@sunce86
Copy link
Contributor

sunce86 commented Apr 8, 2024

Problem

A prerequisite for #2543

Similar how we did with baseline, we also need to make dex solvers return fee in sell token for quote requests.
@MartinquaXD
Copy link
Contributor

A prerequisite for #2543

Isn't it the other way around? I though we should first make it so that solvers don't need the native price to compute quotes and afterwards we switch the system to return fees in sell token instead of just gas.

@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Jun 12, 2024
@sunce86 sunce86 reopened this Jul 11, 2024
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been inactive a while. Please update this issue or it will be automatically closed.

@github-actions github-actions bot added the stale label Sep 10, 2024
@sunce86 sunce86 reopened this Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@MartinquaXD @sunce86 @mfw78