chore: Add more notify call for scoring #2597
Assignees
Comments
Merged
sunce86
added a commit
that referenced
this issue
Apr 5, 2024
# Description Fixes #2493 Fixes #1494 Important notes: 1. ~Removed risk parameter config from solvers - requires cleanup of "riskParameters" in infrastructure repo~ - will be done in a separate PR 2. Solvers api "score" field is optional until solvers update their responses - will be removed completely #2588. Follow ups: 1. cleanup of "riskParameters" in infrastructure repo 3. Update gnosis solvers response https://github.com/gnosis/solvers/blob/main/src/api/routes/solve/dto/solution.rs - gnosis/solvers#10 4. Add more score errors to notify endpoint - #2597 ## How to test Existing tests. No change in behaviour is expected.
sunce86
added a commit
that referenced
this issue
Apr 8, 2024
# Description Related to code review fixes - #2585 (comment) Commented but forgot to actually commit changes before merging. As mentioned, further improvements will be done as part of #2597
m-lord-renkse
added a commit
that referenced
this issue
Apr 22, 2024
# Description Add more notify call for scoring # Changes Add notify calls for the following score errors: - `InvalidExecutedAmount` - `MissingPrice(TokenAddress)` - `CustomPrice(String)` ## How to test 1. e2e 2. unit test ## Related Issues Fixes #2597
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
This issue captures follow up task after #2585 is merged.
Few more notify types should be added:
InvalidExecutedAmountandMissingPricesare probably worth adding.The text was updated successfully, but these errors were encountered: