-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add replacedOrder to metadata #60
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
1902248
to
60bda10
Compare
I have read the CLA Document and I hereby sign the CLA |
recheck |
60bda10
to
34b3910
Compare
Please add a description. Example: #53 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe you still need to modify the compile.ts
as pointed out in the README (contribute section)
This PR is great, only nitpics!
Also @Mateo-mro , please remember is important to add a good description, because reviewer arrive to PRs from working in something else, and might need to be given some context on the motivation and what to expect from the PR. One other thing that is missing, is that you build and commit the autogenerated files. For that, you need to build it You will need to install yarn if you haven't done so: https://classic.yarnpkg.com/lang/en/docs/install/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please take a look at the instructions for adding a new metadata? https://github.com/cowprotocol/app-data?tab=readme-ov-file#contribute
It needs more file changes to properly export all types.
34b3910
to
82c90ac
Compare
I have read the CLA Document and I hereby sign the CLA |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice, thank you!
I have only one nitpick comment, not blocking
validator, | ||
{ | ||
...BASE_DOCUMENT, | ||
metadata: { replacedOrder: { } }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great! thanks for this
70af544
to
05189ac
Compare
Add a new type of metadata:
replacedOrder
This meta-data will allow to specify which order UID to replace when doing a replace order operation.
v1.1.0
compile.ts
to export the new metadata schemaValidations
uid
uid
is the order UID of the order to replace