Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support BSP export for EIP-4844 blob tx (Ethereum Migration v1.5) #244

Merged
merged 32 commits into from
Apr 24, 2024
Merged

Support BSP export for EIP-4844 blob tx (Ethereum Migration v1.5) #244

merged 32 commits into from
Apr 24, 2024

Conversation

noslav
Copy link
Member

@noslav noslav commented Mar 13, 2024 •
edited
Loading

  • Updates all fields related to blob transactions
  • Blobs if detected are auto-formatted into sidecars for block specimens and their respective commits and proofs
  • Codec is upgraded to version 0.37
  • KZG library from Ethereum upstream is used to deal with new blob data fields
  • Lens paths (wrap and unwrap) have been updated for all fields in data that comprise changes

@noslav
support bsp export for eip-4844 blob tx
5533fae 
Signed-off-by: Pranay Valson <[email protected]>
@noslav
go mod tidy
c52e6d0 
Signed-off-by: Pranay Valson <[email protected]>
@codecov Codecov
Copy link

codecov bot commented Mar 26, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.83%. Comparing base (05896a9) to head (560330d).
Report is 6 commits behind head on develop.

Additional details and impacted files 
@@           Coverage Diff            @@
##           develop     #244   +/-   ##
========================================
  Coverage    44.83%   44.83%           
========================================
  Files           28       28           
  Lines         1927     1927           
========================================
  Hits           864      864           
  Misses        1028     1028           
  Partials        35       35

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@noslav
fix blobFeeCap type
f7b54dc 
Signed-off-by: Pranay Valson <[email protected]>
@noslav noslav force-pushed the feature/blob-tx-type branch 2 times, most recently from fd979a4 to d93a7fc Compare March 26, 2024 23:18
@noslav
omit empty blob sidecars
8c9c4f0 
Signed-off-by: Pranay Valson <[email protected]>
@noslav
revert back to optional
a4fe1ad 
Signed-off-by: Pranay Valson <[email protected]>
@noslav noslav mentioned this pull request Apr 18, 2024
Merged
@noslav noslav changed the title Support BSP export for EIP-4844 blob tx Support BSP export for EIP-4844 blob tx (Ethereum Migration v1.5) Apr 24, 2024
@noslav
bump bsp-agent minor version
dd553c9 
Signed-off-by: Pranay Valson <[email protected]>
@noslav
enable extractor scripts to export BlobSideCars
440d1bf 
Signed-off-by: Pranay Valson <[email protected]>
@noslav
disable staticcheck for now
90aecc4 
Signed-off-by: Pranay Valson <[email protected]>
@noslav
linter recom fixes on comments and spacing
2323d71 
Signed-off-by: Pranay Valson <[email protected]>
@noslav
linter recom fixes on redacted/expired libraries
57042ca 
Signed-off-by: Pranay Valson <[email protected]>
@noslav
linter recom fixes for scripts redacted/expired libraries
e3b6a40 
Signed-off-by: Pranay Valson <[email protected]>
@noslav
remove abandoned linters
ec26834 
Signed-off-by: Pranay Valson <[email protected]>
@noslav
match linter to go version local
da6b01b 
Signed-off-by: Pranay Valson <[email protected]>
@noslav
amend linter workflow
f8a850c 
Signed-off-by: Pranay Valson <[email protected]>
rogarcia
rogarcia approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@rogarcia rogarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noslav noslav merged commit e5b923c into develop Apr 24, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sudeepdino008 sudeepdino008 sudeepdino008 left review comments

@rogarcia rogarcia rogarcia approved these changes

@Kakkarrot Kakkarrot Awaiting requested review from Kakkarrot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@noslav @sudeepdino008 @rogarcia