Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Alias XDS missing #52

Open
WhalleyT opened this issue Feb 14, 2024 · 3 comments
Open

Alias XDS missing #52

WhalleyT opened this issue Feb 14, 2024 · 3 comments

Comments

@WhalleyT
Copy link

Hi,

I noticed when running pangolin that the alias keys don't seem to be updated from 1.24 -> 1.25. When running pangolin I get the error

generate_final_report(preprocessing_csv, inference_csv, cached_csv, config[KEY_ALIAS_FILE], constellation_list, config[KEY_PANGOLIN_DATA_VERSION],config[KEY_ANALYSIS_MODE], args.skip_designation_cache, config[KEY_OUTFILE],config)
  File "/lib/python3.8/site-packages/pangolin/utils/report_collation.py", line 234, in generate_final_report
    recombinant_parents = get_recombinant_parents(expanded_pango_lineage, alias_dict)
  File "/lib/python3.8/site-packages/pangolin/utils/report_collation.py", line 94, in get_recombinant_parents
    for parent in alias_dict[lineage_parts[0]]:
KeyError: 'XDS

and I see that in pangolin_data/data/alias_key.json XDS is not there in spite of having been added into pango-designation and it looks like the json is still at 1.24 where the remaining files are at 1.25. Sorry if I'm getting the wrong end of the stick or the files are still in the process of being bumped up!

Thanks, Tom

@AngieHinrichs
Copy link
Member

No, you're right Tom! I accidentally checked out the wrong version of pango-designation when copying in that file. Fixed so it won't happen that way in the future. Stand by for a v1.25.1, sorry about that.

@AngieHinrichs
Copy link
Member

pangolin-data v1.25.1 is out now. Thanks so much for reporting this @WhalleyT!

@WhalleyT
Copy link
Author

That's great! Thanks for the speedy update 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants