Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prof/course IDs should be stable #325

Open
Josh-Cena opened this issue Jul 14, 2024 · 1 comment
Open

Prof/course IDs should be stable #325

Josh-Cena opened this issue Jul 14, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Josh-Cena
Copy link
Member

Right now, imagine users opening the site & downloading the static catalog on day 1, then they keep the site open. On day 2, after a recrawl, they open a modal. The modal would then request related course info using the course ID / prof ID in the static catalog. However, it seems that after the recent rewrites, prof / course IDs are no longer stable, so this may end up showing unrelated courses. We should make sure that if a prof gets assigned an ID, it never changes over time, which means either a change to our ID assignment (which currently is just serial, based on whatever order the table has), or make our DB changes incremental, so only new profs get new IDs (much harder, see #303)

@Josh-Cena Josh-Cena added the bug Something isn't working label Jul 14, 2024
@Josh-Cena
Copy link
Member Author

In 2c55cd8, the course/listing/prof/flag IDs are now stable. Evaluation data and the same-course component IDs are yet to be stable.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant