Skip to content

Commit db3a673

Browse files
daverigbytrondn
authored andcommitted
Fix leaks in compact_functional_test
As reported by ASan: ==25822==ERROR: LeakSanitizer: detected memory leaks Direct leak of 721424 byte(s) in 11 object(s) allocated from: #0 0xffff9f6d18bc in malloc (/opt/gcc-10.2.0/lib64/libasan.so.6+0x9d8bc) #1 0x4b0284 in hash_init ../forestdb/src/hash.cc:32 #2 0x40e254 in _fname_create ../forestdb/src/blockcache.cc:806 #3 0x410698 in bcache_write ../forestdb/src/blockcache.cc:1063 #4 0x457dc8 in filemgr_read ../forestdb/src/filemgr.cc:2147 #5 0x4474d4 in _docio_read_through_buffer(docio_handle*, unsigned long, err_log_callback*, bool) ../forestdb/src/docio.cc:711 #6 0x4474d4 in _docio_read_length ../forestdb/src/docio.cc:803 #7 0x44c8c0 in docio_read_doc ../forestdb/src/docio.cc:1242 #8 0x4d6a3c in fdb_kvs_header_read ../forestdb/src/kv_instance.cc:1142 #9 0x485b94 in _fdb_open ../forestdb/src/forestdb.cc:2076 #10 0x4adfbc in _fdb_recover_compaction(_fdb_kvs_handle*, char const*) ../forestdb/src/forestdb.cc:585 #11 0x4869ac in _fdb_open ../forestdb/src/forestdb.cc:2237 #12 0x486f74 in fdb_open ../forestdb/src/forestdb.cc:848 #13 0x525da0 in compact_rename_to_original_test() ../forestdb/tests/functional/compact_functional_test.cc:525 #14 0x546878 in main ../forestdb/tests/functional/compact_functional_test.cc:3904 #15 0xffff9e4e2ce0 in __libc_start_main (/lib64/libc.so.6+0x1fce0) #16 0x404c4c (/home/couchbase/server/build/forestdb/tests/functional/compact_functional_test+0x404c4c) Direct leak of 721424 byte(s) in 11 object(s) allocated from: #0 0xffff9f6d18bc in malloc (/opt/gcc-10.2.0/lib64/libasan.so.6+0x9d8bc) #1 0x4b0284 in hash_init ../forestdb/src/hash.cc:32 #2 0x40e254 in _fname_create ../forestdb/src/blockcache.cc:806 #3 0x410698 in bcache_write ../forestdb/src/blockcache.cc:1063 #4 0x457dc8 in filemgr_read ../forestdb/src/filemgr.cc:2147 #5 0x4474d4 in _docio_read_through_buffer(docio_handle*, unsigned long, err_log_callback*, bool) ../forestdb/src/docio.cc:711 #6 0x4474d4 in _docio_read_length ../forestdb/src/docio.cc:803 #7 0x44c8c0 in docio_read_doc ../forestdb/src/docio.cc:1242 #8 0x4d6a3c in fdb_kvs_header_read ../forestdb/src/kv_instance.cc:1142 #9 0x485b94 in _fdb_open ../forestdb/src/forestdb.cc:2076 #10 0x486f74 in fdb_open ../forestdb/src/forestdb.cc:848 #11 0x524460 in compaction_delete_old_test() ../forestdb/tests/functional/compact_functional_test.cc:345 #12 0x546874 in main ../forestdb/tests/functional/compact_functional_test.cc:3903 #13 0xffff9e4e2ce0 in __libc_start_main (/lib64/libc.so.6+0x1fce0) #14 0x404c4c (/home/couchbase/server/build/forestdb/tests/functional/compact_functional_test+0x404c4c) Change-Id: I6179654af9da764d4ceed04fb2702ca84f43c874 Reviewed-on: http://review.couchbase.org/c/forestdb/+/159308 Tested-by: Build Bot <[email protected]> Reviewed-by: Trond Norbye <[email protected]>
1 parent 402421e commit db3a673

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

tests/functional/compact_functional_test.cc

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -350,6 +350,8 @@ void compaction_delete_old_test()
350350
TEST_CHK(status == FDB_RESULT_SUCCESS);
351351

352352
// free all resources
353+
fdb_kvs_close(db);
354+
fdb_close(dbfile);
353355
fdb_shutdown();
354356

355357
memleak_end();
@@ -530,6 +532,8 @@ void compact_rename_to_original_test()
530532
TEST_CHK(status == FDB_RESULT_SUCCESS);
531533

532534
// free all resources
535+
fdb_kvs_close(db);
536+
fdb_close(dbfile);
533537
fdb_shutdown();
534538

535539
memleak_end();

0 commit comments

Comments
 (0)