Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Max number of tokens limits usability for Nano S #109

Closed
jhernandezb opened this issue Jan 11, 2024 · 8 comments
Closed

Max number of tokens limits usability for Nano S #109

jhernandezb opened this issue Jan 11, 2024 · 8 comments

Comments

@jhernandezb
Copy link

Recent version of the app reduced the number of tokens in JSON parser from 96 to 70 impacting usability for Nano S users on Cosmos chains that use CosmWasm where the JSON payload are a bit bigger.

We have had users that they cannot longer perform actions that were fine before the upgrade but now they get JSON too big errors.

https://twitter.com/jhernandezb_/status/1745485753474281645

@ftheirs
Copy link
Contributor

ftheirs commented Jan 11, 2024

Hey @jhernandezb, thanks for reporting this issue! We'll work to solve this asap 🙏

@jhernandezb
Copy link
Author

Any updates on this? This is currently affecting a good number of users

@startyNFT
Copy link

Would really appreciate an update, several users are unable to perform actions on Stargaze because of this issue @ftheirs

@vforgeoux-ledger
Copy link

Hey @jhernandezb @startyNFT , would you be able to provide concrete dApps interactions that are failing with the current Cosmos app version on Nano S ? This way I'll be able to give it a try with the fix we're testing. Thanks!

@ainhoa-a
Copy link
Contributor

Fix was already submitted and testing by Ledger is in progress LedgerHQ#34

@jhernandezb
Copy link
Author

jhernandezb commented Feb 26, 2024

Hey @jhernandezb @startyNFT , would you be able to provide concrete dApps interactions that are failing with the current Cosmos app version on Nano S ? This way I'll be able to give it a try with the fix we're testing. Thanks!

we do have a few examples

{
  "account_number": "202429",
  "chain_id": "stargaze-1",
  "fee": {
    "gas": "369729",
    "amount": [
      {
        "amount": "0",
        "denom": "ustars"
      }
    ]
  },
  "memo": "",
  "msgs": [
    {
      "type": "wasm/MsgExecuteContract",
      "value": {
        "contract": "stars1d5frtu2txpy2c5v9jg60wqju2qk8cm8xg3k7s4k863m4hg9mt70sxlxtq2",
        "funds": [],
        "msg": {
          "approve": {
            "expires": {
              "at_time": "1711552995271000000"
            },
            "spender": "stars1fvhcnyddukcqfnt7nlwv3thm5we22lyxyxylr9h77cvgkcn43xfsvgv0pl",
            "token_id": "109"
          }
        },
        "sender": "stars1v7fx7cuum5xz4yu39dwxs7mlje3yptl3k7wum2"
      }
    },
    {
      "type": "wasm/MsgExecuteContract",
      "value": {
        "contract": "stars1fvhcnyddukcqfnt7nlwv3thm5we22lyxyxylr9h77cvgkcn43xfsvgv0pl",
        "funds": [
          {
            "amount": "500000",
            "denom": "ustars"
          }
        ],
        "msg": {
          "set_ask": {
            "collection": "stars1d5frtu2txpy2c5v9jg60wqju2qk8cm8xg3k7s4k863m4hg9mt70sxlxtq2",
            "expires": "1711552995271000000",
            "funds_recipient": "stars1v7fx7cuum5xz4yu39dwxs7mlje3yptl3k7wum2",
            "price": {
              "amount": "10000000000",
              "denom": "ustars"
            },
            "reserve_for": null,
            "sale_type": "fixed_price",
            "token_id": 109
          }
        },
        "sender": "stars1v7fx7cuum5xz4yu39dwxs7mlje3yptl3k7wum2"
      }
    }
  ],
  "sequence": "8"
}

We also have our testnet you can play with if you need so.

@vforgeoux-ledger
Copy link

The Cosmos app has been updated to 2.34.14 version. You can install it from Ledger Live My Ledger tab.

(cc @jhernandezb @startyNFT )

@jhernandezb
Copy link
Author

Thanks! Working now

@ftheirs ftheirs closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants