Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register attestation client and limit updates to registered targets #54

Open
gjermundgaraba opened this issue Aug 22, 2024 · 0 comments

Comments

@gjermundgaraba
Copy link
Collaborator

Currently, the vote extensions doesn't really care if the client updates are registered/configured.

To limit potential for abuse and make it easier to configure each attestation target separately, they should be registered on-chain in the configmodule. This is also where configuration can be set up on things like required voting power (but that will be implemented in #55).

Implementation notes:

  • We also need a way to update a target/registration (naming here might need some thought)
  • We will need GPRC queries (get one, get all with pagination)
  • Check in vote extensions if an incoming client update is registered
  • The AttestorHandler/Controller will need a new method for checking if a client is registered
    • The SufficientAttestations method should also take in the client id for the attestations it is being asked.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant