From 8e2a881d6a14b960bfbd3f53b9b619d6bf8c40d4 Mon Sep 17 00:00:00 2001 From: Adam Tucker Date: Fri, 26 Jan 2024 03:31:02 -0600 Subject: [PATCH 1/3] feat: debug log gRPC queries (#19049) Co-authored-by: Julien Robert --- CHANGELOG.md | 1 + baseapp/baseapp.go | 2 +- baseapp/grpcserver.go | 3 +++ 3 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index a5a2cebe52aa..ee6392809001 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -45,6 +45,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ ### Bug Fixes +* (gRPC) [#19049](https://github.com/cosmos/cosmos-sdk/pull/19049) Add debug log prints for each gRPC request. * (query) [87d3a43](https://github.com/cosmos/cosmos-sdk/commit/87d3a432af95f4cf96aa02351ed5fcc51cca6e7b) Fix collection filtered pagination. ## [v0.50.12](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.50.12) - 2025-02-20 diff --git a/baseapp/baseapp.go b/baseapp/baseapp.go index 4838023fe988..c2cf41989dd2 100644 --- a/baseapp/baseapp.go +++ b/baseapp/baseapp.go @@ -203,7 +203,7 @@ func NewBaseApp( name string, logger log.Logger, db dbm.DB, txDecoder sdk.TxDecoder, options ...func(*BaseApp), ) *BaseApp { app := &BaseApp{ - logger: logger, + logger: logger.With(log.ModuleKey, "baseapp"), name: name, db: db, cms: store.NewCommitMultiStore(db, logger, storemetrics.NewNoOpMetrics()), // by default we use a no-op metric gather in store diff --git a/baseapp/grpcserver.go b/baseapp/grpcserver.go index 1e8f3a91d748..b1befabe9e86 100644 --- a/baseapp/grpcserver.go +++ b/baseapp/grpcserver.go @@ -2,6 +2,7 @@ package baseapp import ( "context" + "fmt" "strconv" gogogrpc "github.com/cosmos/gogoproto/grpc" @@ -64,6 +65,8 @@ func (app *BaseApp) RegisterGRPCServer(server gogogrpc.Server) { app.logger.Error("failed to set gRPC header", "err", err) } + app.logger.Debug("gRPC query received of type: " + fmt.Sprintf("%#v", req)) + return handler(grpcCtx, req) } From 923e8ffa77f653b694bfbbed54169ea5bb0e451e Mon Sep 17 00:00:00 2001 From: aljo242 Date: Wed, 26 Feb 2025 16:38:30 -0500 Subject: [PATCH 2/3] structured logging --- baseapp/grpcserver.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/baseapp/grpcserver.go b/baseapp/grpcserver.go index b1befabe9e86..eed6d50aba24 100644 --- a/baseapp/grpcserver.go +++ b/baseapp/grpcserver.go @@ -65,7 +65,7 @@ func (app *BaseApp) RegisterGRPCServer(server gogogrpc.Server) { app.logger.Error("failed to set gRPC header", "err", err) } - app.logger.Debug("gRPC query received of type: " + fmt.Sprintf("%#v", req)) + app.logger.Debug("gRPC query received", "type", fmt.Sprintf("%#v", req)) return handler(grpcCtx, req) } From 188e00acfaab218dd73737c98b6b4d37aed2526d Mon Sep 17 00:00:00 2001 From: aljo242 Date: Thu, 27 Feb 2025 12:51:29 -0500 Subject: [PATCH 3/3] fix changelog --- CHANGELOG.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index ee6392809001..081507264102 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -45,7 +45,7 @@ Ref: https://keepachangelog.com/en/1.0.0/ ### Bug Fixes -* (gRPC) [#19049](https://github.com/cosmos/cosmos-sdk/pull/19049) Add debug log prints for each gRPC request. +* (gRPC) [#23844](https://github.com/cosmos/cosmos-sdk/pull/23844) Add debug log prints for each gRPC request. * (query) [87d3a43](https://github.com/cosmos/cosmos-sdk/commit/87d3a432af95f4cf96aa02351ed5fcc51cca6e7b) Fix collection filtered pagination. ## [v0.50.12](https://github.com/cosmos/cosmos-sdk/releases/tag/v0.50.12) - 2025-02-20