Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bottom content formatting #6

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Conversation

patudom
Copy link
Contributor

@patudom patudom commented Feb 17, 2024

This hides the bottom logos on narrow screens.
It looks like there are a lot of changes, but a lot of it was updating tabbing, so I could figure out what was actually in the bottom-content div.
I also removed all content associated with the control box, which we were not showing anyway.

I've somehow introduced a new issue where there is a small margin on the right down the whole page. @johnarban or @Carifio24 , if one of you would like to take a quick look, push a commit to fix that, and then merge, please feel free; else I will check on it tomorrow.
Screenshot 2024-02-16 at 7 07 34 PM

@johnarban
Copy link
Contributor

so, I do not have the margin issue that @patudom is having. I have checked on Chrome & Safari. Perhaps @Carifio24 can check this out.

@patudom
Copy link
Contributor Author

patudom commented Feb 18, 2024

Weird. Problem has gone away now that I disconnected from my external monitor. I guess if everything else about the PR looks ok, we can merge and fix this issue if it reappears. Thanks, @johnarban!

@johnarban johnarban merged commit 3e45812 into cosmicds:main Feb 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants