New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OneKey(PublicKey, PrivateKey) constructor does not consistently set `KeyKeys.Algorithm` #114

Open

iaik-jheher opened this issue Apr 10, 2024 · 0 comments

iaik-jheher commented Apr 10, 2024 •

edited

Loading

The OneKey(PublicKey, PrivateKey) constructor does not consistently set the algorithm (3) key in the resulting map.

This causes the resulting CBOR object to violate specs such as the WebAuthn spec, and is just generally poor practice.

(The exception are EDDSA keys, which set the key.)

The text was updated successfully, but these errors were encountered:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment