Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

peerDependencies #26

Open
OndeVai opened this issue Feb 28, 2019 · 1 comment
Open

peerDependencies #26

OndeVai opened this issue Feb 28, 2019 · 1 comment

Comments

@OndeVai
Copy link

OndeVai commented Feb 28, 2019

In your tutorial you include react, react-dom, and styled-components in both "dependencies" and "peerDependencies". With npm 6.4.1 (at least), this seems to have the side effect of installing all 3 without warning the consuming app of unmet dependencies. Maybe worth clarifying in the tutorial.
@coryhouse
Copy link
Owner

Thanks for reporting! I'll leave this open until I patch the course accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@OndeVai @coryhouse