Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

security-check fails #24

Closed
gbm opened this issue Dec 12, 2018 · 6 comments
Closed

security-check fails #24

gbm opened this issue Dec 12, 2018 · 6 comments

Comments

@gbm
Copy link

gbm commented Dec 12, 2018

nsp check
(+) Client request error: getaddrinfo ENOTFOUND api.nodesecurity.io api.nodesecurity.io:443

(running nsp check here on it's own just to show the error)

@coryhouse
Copy link
Owner

nsp was acquired by npm, so it's now built into npm. You no longer need to manually run nsp. Check out this PR for updates on how to run the latest versions.

@gbm
Copy link
Author

gbm commented Dec 12, 2018

thx :) i would suggest either editing the course (which is great) or sticking up one of those blue post it notes

@Chris-43
Copy link

Chris-43 commented Dec 12, 2018 via email

@coryhouse
Copy link
Owner

I've already added a blue note to the relevant clips in the course. That note was added months ago. Did you guys just overlook it?

@Chris-43 - What is your issue?

@gbm
Copy link
Author

gbm commented Dec 13, 2018

I see what happened - yes you are right there is a blue note in the package management section but one is missing in the Automation - Demo: Create Security Check and Share Scripts. [only checking cos I love you ;) ]

@coryhouse
Copy link
Owner

@gbm - Ah! Great catch! I just submitted a patch to add a callout on that clip, and the following clip as well since it shows calling the security-check clip. Thanks! 💯

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants