-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arrange strata to minimize flow overlaps #6
Comments
Working on this in the optimization branch, making use of the iterpc package. Some considerations:
|
The problem with (if necessary, introducing, and) reordering factor levels, and with exporting the function that does so, is that it impacts the behavior of any aesthetics or other features that depend on the factor levels, whether their order or their number. This is turning out to be messier than i'm comfortable with. An alternative approach is to internally construct a Failing this (implicitly passing arguments between layers), i'll develop this feature without the |
From your comments, I'm getting the feeling that this wasn't resolved? I'm having issues with the ordering of the stratum and posted an example here. I probably just am missing something simple but any help would be appreciated. |
This issue (#6) is (still, intermittently) being experimented upon in the optimization branch. I think it's unrelated to the issue you describe at the link. Indeed, strata defined using a factor variable should be arranged in order of the factor levels at any axis. I'll make this a separate issue and get to it ASAP. Thanks for raising it! |
@mbojan points to a good reference at this issue, which i'm closing in order to reduce clutter. |
For cases in which the strata have no intrinsic order, an option should be available to arrange the strata at each axis, perhaps even using different orders at different axes when the strata are repeated (maybe this should be allowed or not according to an additional parameter), in a way that minimizes the number of flow overlaps. The
majors
example in the vignette is a good candidate for such an option.A heuristic algorithm should suffice, and the concept is general enough that it might already be in use somewhere. I won't have time to write one for a while, and it might be worth writing in C and calling via
Rcpp
.The text was updated successfully, but these errors were encountered: