Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: removed space from folder name #232

Merged
merged 4 commits into from
Mar 11, 2024
Merged

fix: removed space from folder name #232

merged 4 commits into from
Mar 11, 2024

Conversation

hirenf14
Copy link
Contributor

What does it do?

Updated Import and directory name for apps/platform/src/views/user.

Why is it needed?

Because of whitespace in directory name at the end, it causes error while cloning.

Related issue(s)/PR(s)

#231

@hirenf14 hirenf14 requested a review from vygandas as a code owner March 11, 2024 08:50
Copy link

vercel bot commented Mar 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
isomera-compodoc ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 11, 2024 9:14am
1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
isomera-landing ⬜️ Ignored (Inspect) Visit Preview Mar 11, 2024 9:14am

Copy link

vercel bot commented Mar 11, 2024

@hirenf14 is attempting to deploy a commit to the Cortip Team on Vercel.

A member of the Team first needs to authorize it.

vygandas
vygandas previously approved these changes Mar 11, 2024
Copy link
Contributor

@vygandas vygandas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks @hirenf14 !

@vygandas
Copy link
Contributor

@hirenf14 could you run linter and prettier and push again because looks like it's not passing that on ci checks https://github.com/cortip/isomera/actions/runs/8230018976/job/22502464319?pr=232#step:5:11

@hirenf14
Copy link
Contributor Author

@hirenf14 could you run linter and prettier and push again because looks like it's not passing that on ci checks https://github.com/cortip/isomera/actions/runs/8230018976/job/22502464319?pr=232#step:5:11

Done. :)

@vygandas vygandas merged commit 2f26102 into cortip:main Mar 11, 2024
8 of 9 checks passed
@vygandas
Copy link
Contributor

@hirenf14 awesome 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants