Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace with @nestjs-modules/mailer with plain nodemailer #134

Closed
vygandas opened this issue Dec 7, 2023 · 0 comments · Fixed by #197
Closed

Replace with @nestjs-modules/mailer with plain nodemailer #134

vygandas opened this issue Dec 7, 2023 · 0 comments · Fixed by #197
Assignees
Labels
back-end Only back-end good first issue Good for newcomers

Comments

@vygandas
Copy link
Contributor

vygandas commented Dec 7, 2023

Problem

@nestjs-modules/mailer causes many security vulnerabilities.

Solution

We do not want this project to be vulnerable, right?
Here's a proposed solution
nest-modules/mailer#1074 (comment)

Acceptance criteria

  • We can still use .hpb templates. When writing this issue, the template email-confirmation.hbs is sent on registration.
  • It should be easy to send emails (easy for developers)
  • It should have its own documentation file in docs/ dir and link to it on the main Readme
@vygandas vygandas added good first issue Good for newcomers back-end Only back-end labels Dec 7, 2023
@PhamAnhHoang PhamAnhHoang linked a pull request Feb 1, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end Only back-end good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants