Use Addressable::URI's normalize_component to ensure special characters are encoded, improve stubbing for new webmock test, remove .editorconfig in this PR for now

Author: toastercup

.editorconfig

@@ -3,7 +3,7 @@
 require 'hashie/mash'
 
 require 'cortex/faraday_middleware/response_failures'
-require 'cortex/faraday_middleware/encode_uri_path'
+require 'cortex/faraday_middleware/normalize_uri_path'
 
 module Cortex
   module Connection
@@ -22,7 +22,7 @@ def connection
       Faraday::Utils.default_uri_parser = Addressable::URI
       Faraday.new options do |conn|
         ## Request middleware first:
-        conn.use Cortex::FaradayMiddleware::EncodeURIPath
+        conn.use Cortex::FaradayMiddleware::NormalizeURIPath
         conn.request :oauth2, access_token.is_a?(OAuth2::AccessToken) ? access_token.token : access_token
         conn.request :json
 

lib/cortex/connection.rb

@@ -3,9 +3,9 @@
 
 module Cortex
   module FaradayMiddleware
-    class EncodeURIPath < Faraday::Middleware
+    class NormalizeURIPath < Faraday::Middleware
       def call(env)
-        env[:url].path = Addressable::URI.encode(env[:url].path)
+        env[:url].path = Addressable::URI.normalize_component(env[:url].path)
 
         @app.call env
       end

lib/cortex/faraday_middleware/encode_uri_path.rb renamed to lib/cortex/faraday_middleware/normalize_uri_path.rb

@@ -17,15 +17,11 @@
     end
 
     context 'with special characters' do
-      before(:all) do
-        stub_request(:get, 'http://cortex.dev/api/v1/posts/feed/1%20post?access_token=123')
-      end
+      let!(:stubbed_request) { stub_request(:get, 'http://cortex.dev/api/v1/posts/feed/1%20post?access_token=123') }
 
       it 'should correctly make the request' do
         client.posts.get_published('1 post')
-
-        expect(a_request(:get, 'http://cortex.dev/api/v1/posts/feed/1%20post?access_token=123')).
-          to have_been_made.once
+        expect(stubbed_request).to have_been_made.once
       end
 
       it 'should not be considered an invalid URI' do