Skip to content
This repository has been archived by the owner on May 16, 2023. It is now read-only.

[CWA-Documentation-Github] CODEOWNERS includes @tkowark #440

Closed
MikeMcC399 opened this issue Oct 10, 2020 · 10 comments · Fixed by #620
Closed

[CWA-Documentation-Github] CODEOWNERS includes @tkowark #440

MikeMcC399 opened this issue Oct 10, 2020 · 10 comments · Fixed by #620
Assignees
Labels
bug Something isn't working documentation Improvements or additions to documentation mirrored-to-jira This item is also tracked internally in JIRA

Comments

@MikeMcC399
Copy link
Contributor

MikeMcC399 commented Oct 10, 2020

Where to find the issue

https://github.com/corona-warn-app/cwa-documentation/blob/master/CODEOWNERS

Describe the issue

@tkowark is listed in several places in the CODEOWNERS document, however he wrote in corona-warn-app/cwa-app-android#1199 (comment) on Sep 24, 2020:

... I will not be around more often as I've transitioned out of the CWA project and are now working on other projects within SAP ...

Suggested change

Check with @tkowark if he should be removed from CODEOWNERS document, then remove or replace his github user name.


Internal Tracking ID: EXPOSUREAPP-4291

@MikeMcC399 MikeMcC399 added bug Something isn't working documentation Improvements or additions to documentation labels Oct 10, 2020
@christianneu
Copy link
Member

Thanks for your input. I will replace contact names soon.

Mit freundlichen Grüßen/Best regards,
CN
Corona Warn-App Open Source Team

@daimpi
Copy link

daimpi commented Oct 12, 2020

@christianneu Just a small OT suggestion: You could add your CWA membership status to your Github profile 🙂.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Oct 13, 2020

@christianneu
Maybe you could check the same for @SebastianWolf-SAP
He also stated that he won't be part of the CWA Project anymore...

@MikeMcC399
Copy link
Contributor Author

@christianneu

I will replace contact names soon.

Something seems to have prevented the change. I still see
@tkowark in https://github.com/corona-warn-app/cwa-documentation/blob/master/CODEOWNERS

@dsarkar dsarkar added the in review Moderators are investigating how to best proceed with the issue label Dec 9, 2020
@dsarkar dsarkar added the mirrored-to-jira This item is also tracked internally in JIRA label Dec 13, 2020
@dsarkar dsarkar removed the in review Moderators are investigating how to best proceed with the issue label Dec 13, 2020
@dsarkar dsarkar changed the title CODEOWNERS includes @tkowark [CWA-Documentation-Github] CODEOWNERS includes @tkowark Dec 13, 2020
@Ein-Tim
Copy link
Contributor

Ein-Tim commented Feb 3, 2021

Any updates? The cwa-website repo also still includes @SebastianWolf-SAP as a CODEOWNER.

I could provide a PR here and in the website repo which removes the old CODEOWNERS, but I suggest that you do that and add a new CODEOWNER.

@dsarkar
Copy link
Member

dsarkar commented Feb 4, 2021

@Ein-Tim Thanks for the offer. We will ask for updates.

@MikeMcC399
Copy link
Contributor Author

@dsarkar
Of course this is SAP's decision, but it seems strange to keep out-of-date names in the
CODEOWNERS document for this repository.

@MikeMcC399
Copy link
Contributor Author

Closing due to lack of progress.

@Ein-Tim
Copy link
Contributor

Ein-Tim commented Apr 23, 2021

The Codowners of the website repo were updated.
I suggest that you do the same in this repository.

@heinezen
Copy link
Member

Fix is coming in #620

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working documentation Improvements or additions to documentation mirrored-to-jira This item is also tracked internally in JIRA
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants