-
Notifications
You must be signed in to change notification settings - Fork 285
Update to 1.5.0 turns 7 day old high risk encounters to low risk #1365
Comments
Hey @fabboe , Thanks for reporting the issue. Could you provide the ENF logs for us? This would help us to better investigate your problem. Thanks, Corona-Warn-App Open Source Team |
I also had the problem that yesterday my app warned me about a high risk encounter (red screen) about 2 days ago, but today after the update the app shows again only low risk encounters (green screen). Unfortunately I have only the export of the matching of today, where all (The technical hotline could not answer the question about the difference between yesterday and today.) Update: I updated to iOS 14.1 today as well. Curious to see my match results tonight. |
@fabboe |
@norbertschuler thanks for reporting. Great that you're now on iOS 14.1 👍. Could you also share your EN log here after your CWA sync tonight? |
Updated to 14.1 and it synced right afterwards: https://pastebin.com/9mDZiQkz Match count now matches number of encounters in app. Hope that helps. |
@heinezen I do think there is something fishy going on here… the sudden change of risk right when updating to CWA 1.5 is a bit too unlikely especially as the number of encounters stayed exactly the same… unfortunately @fabboe number of contacts went now down by one, but right after the update it was still at five… For a coincidence both of them would have to phase out an old high-risk contact and replace it with a new low risk one right at the time when they updated to CWA 1.5, that sounds extremely improbable. It's imho much more likely that something in the risk calculation changed… Question would o/c be whether the new calculation or the old one was working correctly. I think it would be good to have some devs look into this to get more clarity on this issue. |
In theory I have still three more days to phase out of the previous high risk encounter. Also I asked the high risk encounter whether they removed the positive test result from the app - they didn't. In the pool of high-risk encounters of the very same positive test there's at least one more such example - turned green. In these times the risk scoring should become more conservative - not less :) |
I took a closer look at @fabboe's log. Here is a potentially interesting output:
I filtered for But there is one interesting observation: the hash for what is highly likely the same package changes between 18th and 19th i.e. the hash for the package changed with the update to CWA 1.5 even though One thing which came to my mind in this context: federation roaming was introduced together with CWA 1.5 could there be some connection? Also: the hash for the package on the 18th can be found here and as expected is timestamped 2020-10-17. The new hash is not listed there (this actually applies for all the hashes in the log from after the update to CWA 1.5 which I spot checked). |
I can confirm a change in the hash values for the files with the same amount of key counts between |
@norbertschuler thanks for sharing, looking forward to your new log with iOS 14.1 🙂. |
Hey @daimpi This is the Screenshot of the EN-Log before the Update to Version 1.5.0: And this is a Screenshot of the EN-log after the Update to Version 1.5.0: As you can see all Hash Names changed and also these are not the same which are shown here... @thomasaugsten Can you confirm that this Behaviour is planed and that there is nothing which did go wrong with the update? |
Can it be a change on the server side? E.g. different risk parameters, or the risk values associated with the keys? |
At least the config parameters for CWA seem not to have changed. The most recent changes there were conducted mid of September. |
My todays matching (on iOS 14.1 with app version 1.5.0 (8)) shows 10 low risk results (one less then before) and still no more high risk in the exported exposure checks, e.g. for the timestamp
which by the way had no match count yesterday at
and a different hash the day before at
Here is my exported file: ExposureChecks-2020-10-22.json.zip |
@norbertschuler was your device in Germany during the risk encounters and during the recent matching? Just to rule out that this is a corner case due to introduction of roaming (my risk encounters were outside of Germany, with another German device). If I recall correctly the roaming prefixes the keys/hashes with a current-country-specific part - this could explain the changed hashes. |
In my case I have been in Germany in my home town all the time. |
@norbertschuler on which day did you update to iOS 14.1? |
Ok, that's an explanation as I updated yesterday (2020-10-21 after the nightly matching job) to iOS 14.1, so only the ENF log of today is showing match counts. |
the package you matched with (pre 1.5 hash: @fabboe the keys from federation roaming look the same as those from the Germany at least once they are distributed by the national servers:
@heinezen I think you can remove the "further input needed" label… We probably now have all the info we can get and need someone familiar with the changes on the server and CWA side to investigate this. |
@daimpi @norbertschuler @fabboe Yes, looks like the devolopers can take over. Thanks for all the input. It's mirrored to the internal Jira now (ticket ID: EXPOSUREAPP-3402), so the devs can pick it up. CH Corona-Warn-App Open Source Team |
The specific issue can be closed indeed. Up to the dev team to decide investigating the underlying problem that might reappear under different issues. |
Since Sunday (Oct 18) I had a five risk encounters shown, last one 7 days ago. High risk. This morning just before updating the app as well.
After updating now to iOS 1.5.0 (iOS 14.0.1 unchanged) there was a new sync and suddenly I have only five low risk encounters.
The high risk encounter was outside of Germany between to German CWA/phones. It was in a country that's not yet listed as participating.
No more high risk. Bug? Feature?
Or was the previous high risk a bug?
I don't think so, since I know the person who entered a positive test and our (actual high risk) encounter matched the previous app information.
1.5.0 touched risk scoring in at least these PRs: #1137 #1060 #1265 #1162
ENF logs:
https://pastebin.com/f027GYK1
https://pastebin.com/9mDZiQkz
Internal Tracking ID: EXPOSUREAPP-3402
The text was updated successfully, but these errors were encountered: