Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cine Decimal String is not parsed correctly #144

Open
horner opened this issue Jun 21, 2022 · 2 comments
Open

Cine Decimal String is not parsed correctly #144

horner opened this issue Jun 21, 2022 · 2 comments

Comments

@horner
Copy link
Contributor

horner commented Jun 21, 2022 •
edited
Loading

All Cine images I have tested use a Decimal String to store Frame Time
0018:1063 DS 6 Frame Time {18.943}

dataSet.float('x00181063') should be floatString('x00181063');

react-cornerstone-viewport/src/metadataProvider.js

Line 113 in 52703b9

frameTime: dataSet.float('x00181063'),

Screen Shot 2022-06-21 at 6 28 40 PM
@horner
Copy link
Contributor Author

horner commented Jun 21, 2022

@dannyrb Shouldn't this be changed to floatString('x00181063');?

horner added a commit to horner/react-cornerstone-viewport that referenced this issue Jun 21, 2022
@horner
cineModule parses DS floatString instead of float
6db5ba6 
cornerstonejs#144
@horner horner mentioned this issue Jun 21, 2022
Merged
@horner
Copy link
Contributor Author

horner commented Aug 4, 2022

@swederik I say you closed my other PR (cornerstonejs/cornerstoneWADOImageLoader#453), but this issues (and related PR) is important too.

sedghi pushed a commit that referenced this issue Aug 26, 2022
@horner
fix: cineModule parses DS floatString instead of float (#145)
3070c61 
#144
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@horner