Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removeToolState() won't work if you provide another instance of "data" object, even if uuid is the same. #1546

Open
osx11 opened this issue Jun 9, 2023 · 0 comments
Open

removeToolState() won't work if you provide another instance of "data" object, even if uuid is the same. #1546

osx11 opened this issue Jun 9, 2023 · 0 comments

Comments

@osx11
Copy link

osx11 commented Jun 9, 2023

Please review this line: https://github.com/cornerstonejs/cornerstoneTools/blob/79d0ee1560950e54234353f77b22b8257cc47540/src/stateManagement/toolState.js#LL95C5-L95C5

Why don't you use data.uuid here for comparison? If I have different data objects, containing same values, it is still the same data, but the condition will fail as it is a different instance of the same object. Perhaph you should compare by uuid here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@osx11