Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reference lines do not show using v0.1.9 for MRI-3T #39

Open
septembersoul opened this issue May 12, 2021 · 3 comments
Open

Reference lines do not show using v0.1.9 for MRI-3T #39

septembersoul opened this issue May 12, 2021 · 3 comments
Labels

Comments

@septembersoul
Copy link

Reference lines do not show using v0.1.9 for MRI-3T studies (axial/sagittal series).
v0.1.8 works fine.

I'm using

  • Cornerstone v2.3.0
  • Tools v5.1.4
  • DicomParser v1.8.7
@jpinxten
Copy link

I'm having the same issue, reverting to v0.1.8 also fixes it for me.

  • cornerstone-core v2.6.0
  • cornerstone-tools v6.0.2
  • cornerstone-wado-image-loader v4.0.4

https://github.com/cornerstonejs/cornerstoneTools/blob/e81f1b6c5e2fec31d5641f7f95a8f9925e92eb1e/src/util/pointProjector.js#L119-L131

This function always returns 0 intersections

@swederik swederik added the bug label Oct 14, 2021
@swederik
Copy link
Member

Maybe broken by @ladeirarodolfo in this commit? 825a7b5

@septembersoul
Copy link
Author

In my case issue appears here

if (s > 1.0 || isNaN(s)) {

I changed it to if (s >= 1.1 || isNaN(s)) and reference lines became visible.
Value of s variable was about 1.0938...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants