Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generation of MethodDoc #22

Open
zainengineer opened this issue May 21, 2016 · 4 comments
Open

generation of MethodDoc #22

zainengineer opened this issue May 21, 2016 · 4 comments

Comments

@zainengineer
Copy link
Contributor

Hi @cornernote ,

this commit 32fac64 resulted in docs for methods not generating.
I looked at code and could not find why it was disabled.
On my local it works fine, If I revert the changes.

@cornernote
Copy link
Owner

Hey @zainengineer

Which version of Yii are you using?

This change was intended to remove all the static methods with Yii 1.1.16+ because they all have @return static in Yii core.

@zainengineer
Copy link
Contributor Author

@cornernote In composer.lock It is using https://github.com/yiisoft/yii/tree/bca0420b6799b0b2a7966aa90bcd15cb4aa73563 which is yii 1.1.16
Although model() docBlock suggests it is static https://github.com/yiisoft/yii/blob/bca0420b6799b0b2a7966aa90bcd15cb4aa73563/framework/db/ar/CActiveRecord.php#L389

But it is always constructed using new ClassName
So type hinting is still correct and useful.
There is an already an option to not include it, so dev can exclude it if required.

@cornernote
Copy link
Owner

So it's working correctly?

@zainengineer
Copy link
Contributor Author

@cornernote If I revert 32fac64 it works correct
generated doc block work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants