Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request - Add option to remove configs too #15

Open
vikas027 opened this issue Apr 25, 2020 · 2 comments
Open

Feature Request - Add option to remove configs too #15

vikas027 opened this issue Apr 25, 2020 · 2 comments

Comments

@vikas027
Copy link

Thanks for the handy plugin. Please enable the option to delete/remove configs too

In other words, something similar to the below commands

kubectl config delete-cluster my-cluster
kubectl config delete-context my-cluster-context
kubectl config unset users.my-cluster-admin
@corneliusweig
Copy link
Owner

That's a nice idea. Do you miss this functionality in general or for konfig in particular? I'm asking because other plugins have already solved this problem quite nicely I think. For example, kubectx is pretty good.

FWIW, I think delete-cluster is dangerous or not easy to implement properly: the cluster could be referenced in several contexts and it is ambiguous what people expect to happen. IMO, better err on the safe side which means not deleting if it is referenced. And then it's not better than delete-context anymore, but more complex to implement.

@vikas027
Copy link
Author

Hey @corneliusweig ,

Yeah, I know some other projects have done the same but it would be good to have everything at one place.

FWIW, I think delete-cluster is dangerous or not easy to implement properly: the cluster could be referenced in several contexts and it is ambiguous what people expect to happen. IMO, better err on the safe side which means not deleting if it is referenced. And then it's not better than delete-context anymore, but more complex to implement.

I understand that this could be a bit disastrous if not done properly, but we can always have automatic backups which people can roll back if they wish to.

Overall, I leave it to you. To me, it makes sense to have this feature, especially when dealing with al lot ephemeral clusters at times.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants