-
-
Notifications
You must be signed in to change notification settings - Fork 157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Help wanted] Slug field inside localized fields and unique constraints #2782
Comments
@shadowinek hey, thanks for using CoreShop :) Why are you blocked on 3.0.5? My suggestion would be to just overwrite the Slugger and create your own that disables or not uses the language fallbacks. Is this bug still available in the latest 3.2 and something we can fix or help with? You can also contact me directly under [email protected] if you don't know how to solve it and we can help you directly. |
Hey @dpfaffenbauer, thanks for the quick reaction. By blocked I meant more of a soft block. For now we extended the From the changelog I can see that the So we found a solution, but I am not really sure it is a correct way how to deal with it and wanted to find if anyone encountered the same issue we have. The only similar issue I found on pimcore repository, but this feels more connected to coreshop to me - pimcore/pimcore#11697 |
I am pretty sure its a bug, but not sure if its fixed already. so in your case, I would just go on, see if it works and let me know again if it doesn't. and then we can properly fix it. |
@shadowinek any update? |
Hi,
I need a help with our issue we have. We are currently in the process of upgrading CoreShop to the latest versions. Currently we are blocked by version 3.0.5, because of this bugfix - #2236
Our setup
We have a
![Image](https://private-user-images.githubusercontent.com/404089/404310803-1f7e84ab-4bfb-4225-8502-ce1a1d57c14e.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMDc2ODMsIm5iZiI6MTczOTAwNzM4MywicGF0aCI6Ii80MDQwODkvNDA0MzEwODAzLTFmN2U4NGFiLTRiZmItNDIyNS04NTAyLWNlMWExZDU3YzE0ZS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQwOTM2MjNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1kZGNiYTAxZjA1ZDU4Yjc3NGU1MTY1MDZmNzYzOTg0MDY1N2I5NDkwZDAxNTY0MTYyOGRmODA5YThiNTZlYzQxJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.bxF92nwmt5bq3GL-FB5thGF91PBieYIPd0tGUWUyvhc)
CoreShopProduct
, that includesslug
field type insideLocalized fields
We have multiple languages and some of them have fallback.
![Image](https://private-user-images.githubusercontent.com/404089/404311545-7384eeed-9164-4f2c-9f91-0388dd5933d0.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMDc2ODMsIm5iZiI6MTczOTAwNzM4MywicGF0aCI6Ii80MDQwODkvNDA0MzExNTQ1LTczODRlZWVkLTkxNjQtNGYyYy05ZjkxLTAzODhkZDU5MzNkMC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQwOTM2MjNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT00MGI1OTYyYWUwNmU3ZDc1NDAxYmJkYzlmMjNiMWIzZjQyMWY5ODNjZmIwNDdhMzY2MmEwNDc2MjI1Yzc4MWMyJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.HArl37uKvftVHslFj8c7rewNA9JE4H99FoH5QSgKp_E)
Our issue
After the upgrade we are getting an error page
![Image](https://private-user-images.githubusercontent.com/404089/404312246-71e62f7a-1323-4d73-9a0f-904086446ccd.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkwMDc2ODMsIm5iZiI6MTczOTAwNzM4MywicGF0aCI6Ii80MDQwODkvNDA0MzEyMjQ2LTcxZTYyZjdhLTEzMjMtNGQ3My05YTBmLTkwNDA4NjQ0NmNjZC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjA4JTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIwOFQwOTM2MjNaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT1iNDcwOWRjMjIwZjA1OTMxYzJmYTc0NWNiODU0MWY4Yzg5MzZiNTZkY2JlOTU5N2VmYTZiMGVkMGEyMTcwMTU4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.2h_Mj1zM902BIB6oOCDdZKrvdcNmE0c1p91Csq51MNU)
This is caused, because we are trying to create "blank" product that is then possible to edit with data. While creating this product the slugs for all languages are getting generated. This is no issue for the languages without fallback language. But when a language has a fallback, we get a duplicated slug. When we try to save the object, we get an error.
Example slugs before the change:
Language: en - /en/678a5894d1c76-2025-01-17-14-18-12
Language: de - /de/678a5894d1c76-2025-01-17-14-18-12
Language: fr - /fr/678a5894d1c76-2025-01-17-14-18-12
Language: es - /es/678a5894d1c76-2025-01-17-14-18-12
Language: it - /it/678a5894d1c76-2025-01-17-14-18-12
Example slugs after the change:
Language: en - /en/678a586975333-2025-01-17-14-17-29
Language: de - /de/678a586975333-2025-01-17-14-17-29
Language: fr - /en/678a586975333-2025-01-17-14-17-29
Language: es - /en/678a586975333-2025-01-17-14-17-29
Language: it - /en/678a586975333-2025-01-17-14-17-29
Questions
Thanks.
The text was updated successfully, but these errors were encountered: