Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use configurable output, not the logger #56

Open
theseion opened this issue Nov 19, 2022 · 2 comments · May be fixed by #59
Open

Use configurable output, not the logger #56

theseion opened this issue Nov 19, 2022 · 2 comments · May be fixed by #59
Labels
enhancement New feature or request

Comments

@theseion
Copy link
Collaborator

Regular program output shouldn't run through the logger. Instead, use a configurable output, such that tests can read the output instead of stdout.

The log level should be changed to warning or error. Many of the informational messages probably need to be changed to use the output.

The output should also control printing for different configurations, e.g. for GitHub.
@theseion theseion added the enhancement New feature or request label Nov 19, 2022
@theseion theseion mentioned this issue Nov 19, 2022
Open
@fzipi
Copy link
Member

fzipi commented Nov 20, 2022

I started a draft using zerolog adapting the ConsoleWriter for writing to github in #59.

@fzipi
Copy link
Member

fzipi commented Nov 20, 2022

I think this needs a major rework. We need to encapsulate the log as right now every sublogger we create is not being created from the base log, but from zerolog/log.

And probably adding a new GithubWriter instead of the ConsoleWriter would simplify things in the future.

@fzipi fzipi linked a pull request Feb 27, 2024 that will close this issue
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add new formatter log output for github coreruleset/crs-toolchain
2 participants
@theseion @fzipi