Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss enabling rpm-ostree cliwrap #730

Closed
bgilbert opened this issue Feb 2, 2021 · 6 comments
Closed

Discuss enabling rpm-ostree cliwrap #730

bgilbert opened this issue Feb 2, 2021 · 6 comments

Comments

@bgilbert
Copy link
Contributor

bgilbert commented Feb 2, 2021

This is a pointer issue for coreos/fedora-coreos-config#830 to raise visibility. That PR proposes to replace the dracut, grubby, and rpm commands with wrappers that don't allow modifying the system.

I'm locking this issue; please discuss in the above-linked PR.

@bgilbert bgilbert added meeting topics for meetings kind/enhancement labels Feb 2, 2021
@coreos coreos locked and limited conversation to collaborators Feb 2, 2021
@jlebon
Copy link
Member

jlebon commented Feb 17, 2021

(Cross-posting)

This was discussed in the community meeting:

AGREED: We will turn on cliwrap in the FCOS next stream to gain feedback. We will document it, and send an email to coreos-status. We will file an f35 Change before turning it on on all streams (as well as possibly other rpm-ostree variants like FSB and IoT).

@jlebon jlebon removed the meeting topics for meetings label Feb 17, 2021
@jlebon jlebon added the meeting topics for meetings label Feb 21, 2024
@prestist prestist removed the meeting topics for meetings label Feb 21, 2024
@prestist
Copy link
Contributor

prestist commented Feb 21, 2024

We talked about his in the meeting today:
AGREED: Enable cliwrap with f40 rebase; Additionally communicate this to our users by updating https://github.com/coreos/fedora-coreos-tracker/issues/1655 (@spresti:fedora.im, 17:09:05)

@jlebon
Copy link
Member

jlebon commented Mar 5, 2024

Note coreos/fedora-coreos-config#2887 changes the proposal so that we only wrap dnf since that's the one we care most about (and kernel-install, until coreos/rpm-ostree#4726 is fixed). As previously discussed, wrapping other commands that already exist in the OS is confusing and can cause (and already has caused) issues.

@coreos coreos unlocked this conversation Mar 7, 2024
@jlebon
Copy link
Member

jlebon commented Mar 8, 2024

Instead of this, I now propose #1687.

@jlebon
Copy link
Member

jlebon commented Mar 8, 2024

Instead of this, I now propose #1687.

Another reason why the cliwrap path is not great that became more obvious as I dug into it is that the CLI is far from parity. dnf install works, but for replacing existing packages, you'd still have to do rpm-ostree override replace (i.e. rpm-ostree still tries to maintain the distinction it makes client-side between layering and overriding -- this information would be nice to maintain in the derivation flow, but a nicer way to do that is at the container image layer level instead). We could fix that of course, but if we agree to ship dnf anyway eventually then it doesn't seem like the best use of our time.

@jlebon
Copy link
Member

jlebon commented Mar 26, 2024

Closing in favour of #1687.

@jlebon jlebon closed this as not planned Won't fix, can't repro, duplicate, stale Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants