{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":35116931,"defaultBranch":"main","name":"vboot","ownerLogin":"coreboot","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-05-05T18:30:40.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/6484311?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1727180376.0","currentOid":""},"activityList":{"items":[{"before":null,"after":"323b523c0f47221185378745fc9852593688db43","ref":"refs/heads/firmware-nissa-15217.279.B","pushedAt":"2024-09-24T12:19:36.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"firmware: Die on zero size errors vb2api_get_firmware_size()\n\nBUG=none\nBRANCH=none\nTEST=make runtests -j8\n\nSigned-off-by: Jakub Czapiga \nDisallow-Recycled-Builds: test-failures\nChange-Id: I9c22627410836906a84c387377facc778dd77f3b\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3986523\nTested-by: Jakub Czapiga \nReviewed-by: Julius Werner \nCommit-Queue: Jakub Czapiga \nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4005142\nReviewed-by: Reka Norman \nCommit-Queue: Reka Norman \nTested-by: Kangheui Won \nReviewed-by: Hung-Te Lin ","shortMessageHtmlLink":"firmware: Die on zero size errors vb2api_get_firmware_size()"}},{"before":"80955816aee0bcac10628c1f574b1a2a9b06f1c5","after":"da1d153b4eed5f53f40e89b4f8a706711cf0f0eb","ref":"refs/heads/main","pushedAt":"2024-09-24T08:19:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"Move futility and cgpt to vendor partition\n\nThis patch is a cherrypick of:\ncommit ef8f3c8635a6 (\"Move futility and cgpt to vendor partition\")\nCherry-picked to synchronize ChromeOS and Android repos.\n\nBUG=b:366170141\nTEST=m\nBRANCH=None\n\nTest: m\nBug: b:366170141\nChange-Id: I96b9b86868540d20e7d8488fbcb38e91b3d3b40e\nSigned-off-by: Jakub Czapiga \nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5882100\nReviewed-by: Hung-Te Lin ","shortMessageHtmlLink":"Move futility and cgpt to vendor partition"}},{"before":"7ad2b0ab50350df901de329a75aa40d189ef6f94","after":"80955816aee0bcac10628c1f574b1a2a9b06f1c5","ref":"refs/heads/main","pushedAt":"2024-09-23T22:19:31.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"futility: updater: Remove 'allow_empty_custom_label_tag' quirk\n\nThe 'allow_empty_custom_label_tag' quirk was introduced for non-unified\nbuilds to support custom label devices without a tag (customization_id)\nset. The only device use it is Hana, which is now a unified build.\n\nAfter CL:5872452, we are now able to directly load the default keys\nusing the information provided by `signer_config.csv` even for Hana (and\nremoved where the quirk was previously used), so this quirk is no longer\nneeded.\n\nBUG=b:251040363\nTEST=make runfutiltests -j\nBRANCH=None\n\nChange-Id: I14edd5f89d3518a4ba936a6c4df5e91368d03783\nSigned-off-by: Hung-Te Lin \nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5879037\nCommit-Queue: ChromeOS Auto Retry \nReviewed-by: Yu-Ping Wu ","shortMessageHtmlLink":"futility: updater: Remove 'allow_empty_custom_label_tag' quirk"}},{"before":"13400d696a5edaff2b28c1305ca1069e6bbb9669","after":"7ad2b0ab50350df901de329a75aa40d189ef6f94","ref":"refs/heads/main","pushedAt":"2024-09-23T16:18:45.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"futility: updater: Process custom label as standard models\n\nOne advantage of switching to signer_config.csv and getting rid of\nsetvars.sh is we finally can know what custom label devices are\nsupported.\n\nIn `setvars.sh` or the pre-Unified-Build single package format, we have\nto scan the 'keyset/' folder to figure out what custom label tags may be\navailable. But when using signer_config.csv, all the custom label names\nare already included in the signer information.\n\nAs a result, we can finally remove the hacky way of patching custom\nlabel devices. One downside is we can no longer support custom label in\nnon-Unified-Build systems, but all active Chromebooks are now Unified\nBuild so that is not a problem. And for development using simple archive\nwithout `signer_config.csv`, there is no need to support custom label\nbecause we usually don't have signed keys.\n\nThis is also the first step to remove the custom label logic from the\nfirmware updater - preparation to let crosid handle custom label\nmatching for us. This also implies `--signature_id` is now equivalent to\n`--model` and can be deprecated in the follow up changes.\n\nBUG=b:251040363\nTEST=make runfutiltests -j\nBRANCH=none\n\nChange-Id: Ib4c62ba4d01b276472575625ea19397fc21b1589\nSigned-off-by: Hung-Te Lin \nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5872452\nCommit-Queue: Yu-Ping Wu \nReviewed-by: Yu-Ping Wu ","shortMessageHtmlLink":"futility: updater: Process custom label as standard models"}},{"before":"ed4556edb968be5781237353eb0db56fcadaec1c","after":"13400d696a5edaff2b28c1305ca1069e6bbb9669","ref":"refs/heads/main","pushedAt":"2024-09-23T10:20:09.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"futility: updater: Remove signature_id from manifest\n\nThe `signature_id` was a legacy data from `setvars.sh` and was not\navailable in the `signer_config.csv` data. Since we have fully\ndeprecated the `setvars.sh`, it is time to remove the unused data.\n\nBUG=b:251040363\nTEST=make runfutiltests -j\nBRANCH=none\n\nCq-Depend: chromium:5874495\nChange-Id: I7cb690b2bc4e0de96e062c7087b92483d440cda4\nSigned-off-by: Hung-Te Lin \nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5837957\nReviewed-by: Yu-Ping Wu \nCommit-Queue: Yu-Ping Wu ","shortMessageHtmlLink":"futility: updater: Remove signature_id from manifest"}},{"before":"bc2317695965bb92b8809d9c06327adedcb0653c","after":"1a2097e1339fa4ea8fcc2c77a92d38edf47676db","ref":"refs/heads/factory-dedede-13683.B","pushedAt":"2024-09-23T10:20:09.000Z","pushType":"push","commitsCount":5,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"futility: updater: Enable keyset in signer_config based manifest\n\nFor custom label devices, the 'keyset' folder must be available\n(has_keyset) and that check was done only in setvar based manifest\nbuilder (e.g. 'manifest_scan_entries').\n\nTo support custom label devices correctly, we have to also check keyset/\nfolder in the manifest_from_signer_config.\n\nBUG=b:251040363,b:365926061\nTEST=make; FEATURES=test emerge vboot_reference chromeos-firmware-$BOARD\nBRANCH=None\n\nChange-Id: I642d3380986890a092b6771f8c7128bfc39811e4\nSigned-off-by: Hung-Te Lin \nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/4776002\nCommit-Queue: Yu-Ping Wu \nReviewed-by: Yu-Ping Wu \n(cherry picked from commit 11bdc1f5d674b511649ab0243fe7c66c051dc4fa)\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5859518\nCommit-Queue: Shou-Chieh Hsu \nReviewed-by: Shou-Chieh Hsu ","shortMessageHtmlLink":"futility: updater: Enable keyset in signer_config based manifest"}},{"before":"5a174c68cd1a610aff5d470cc7261dbb5af2ee27","after":"604d7e4c7952b037f82e8c3c301cf701f153efc4","ref":"refs/heads/firmware-android-15949.B","pushedAt":"2024-09-20T18:19:54.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"tests/futility: Add test cases for unmodified RO\n\nTest the futility 'autoupdate' mode when the RO section is the same in\nboth the old and new firmware versions.\n\nRegardless of whether write protection (WP) is true or false, futility\nshould only update the inactive firmware (RWB).\n\nBUG=b:194910959\nTEST=manual on tentacruel.\nTEST=unit tests passed.\n\n(cherry picked from commit ed4556edb968be5781237353eb0db56fcadaec1c)\n\nChange-Id: I35f9017f891e12bee8aff121d1eed8a008fbe4ae\nOriginal-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5869471\nOriginal-Reviewed-by: Yu-Ping Wu \nOriginal-Tested-by: Yu-Ping Wu \nOriginal-Reviewed-by: Jeremy Bettis \nOriginal-Tested-by: Dennis Yeh \nOriginal-Commit-Queue: Dennis Yeh \nGitOrigin-RevId: ed4556edb968be5781237353eb0db56fcadaec1c\nCr-Build-Id: 8736283100860560977\nCr-Build-Url: https://cr-buildbucket.appspot.com/build/8736283100860560977\nCopybot-Job-Name: android-main-vboot_reference-copybot-downstream\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5874415\nTested-by: ChromeOS Prod (Robot) \nCommit-Queue: Grzegorz Bernacki \nReviewed-by: Grzegorz Bernacki ","shortMessageHtmlLink":"tests/futility: Add test cases for unmodified RO"}},{"before":"5241706e05ad66fc43c262bfc8eebebefdf1ee00","after":"b2bbd51afcb726feec588d2b2aa9074c58e4deac","ref":"refs/heads/firmware-android-dedede-13606.653.B","pushedAt":"2024-09-20T18:19:54.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"cgptlib: Add helper function for finding pvmfw\n\nThis changes add a new function for finding pvmfw partition from disk.\nThis function will used by the following patches.\n\nBUG=b:354045389\nBUG=b:359340876\nTEST=Check if the contents matches with partition\nBRANCH=firmware-android-15949.B\n\n(cherry picked from commit 07270417d3824db7233b4a85cf2c8363744d873d)\n\nChange-Id: I4814c62a52cb2cdc0682964527d214a94f6375e3\nOriginal-Signed-off-by: Bartłomiej Grzesik \nOriginal-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5816953\nOriginal-Reviewed-by: Konrad Adamczyk \nOriginal-Reviewed-by: Jakub Czapiga \nGitOrigin-RevId: 07270417d3824db7233b4a85cf2c8363744d873d\nCr-Build-Id: 8736283101061360225\nCr-Build-Url: https://cr-buildbucket.appspot.com/build/8736283101061360225\nCopybot-Job-Name: android-main-fw-dedede-vboot_reference-copybot-downstream\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5869452\nTested-by: Kornel Dulęba \nTested-by: ChromeOS Prod (Robot) \nCommit-Queue: Kornel Dulęba \nReviewed-by: Kornel Dulęba ","shortMessageHtmlLink":"cgptlib: Add helper function for finding pvmfw"}},{"before":"0030800ea14fe36194ad115a74e629f2bbeb44c6","after":"5241706e05ad66fc43c262bfc8eebebefdf1ee00","ref":"refs/heads/firmware-android-dedede-13606.653.B","pushedAt":"2024-09-20T16:18:57.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"avb: fix subtraction overflow in init boot offset calculation\n\nThis small patch swaps subtraction operants in init_boot_size. The later\noperant always had a greater value than the left operant. This causes\nthe value to overflow and reach the values in neighborhood of ~4GB,\nwhich is invalid.\n\nThis is a nit rather than fix, since the sole use of the value is added\nback to init_boot_offset, which overflows back to a correct value.\n\nBUG=b:359340876\nTEST=Build FW and boot android\nBRANCH=firmware-android-15949.B\n\n(cherry picked from commit 6cada6496a77337185d6f8bcc9a9c3e4937dea65)\n\nChange-Id: I838675bed8dfb94dfdce4f9c1e147cc3128a04b6\nOriginal-Signed-off-by: Bartłomiej Grzesik \nOriginal-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5809178\nOriginal-Reviewed-by: Konrad Adamczyk \nOriginal-Reviewed-by: Jakub Czapiga \nOriginal-Reviewed-by: Grzegorz Bernacki \nGitOrigin-RevId: 6cada6496a77337185d6f8bcc9a9c3e4937dea65\nCr-Build-Id: 8736283101061360225\nCr-Build-Url: https://cr-buildbucket.appspot.com/build/8736283101061360225\nCopybot-Job-Name: android-main-fw-dedede-vboot_reference-copybot-downstream\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5869451\nTested-by: ChromeOS Prod (Robot) \nCommit-Queue: Kornel Dulęba \nTested-by: Kornel Dulęba \nReviewed-by: Kornel Dulęba ","shortMessageHtmlLink":"avb: fix subtraction overflow in init boot offset calculation"}},{"before":"2190262902561e5e57b088235f6e7302003f1c3b","after":"ed4556edb968be5781237353eb0db56fcadaec1c","ref":"refs/heads/main","pushedAt":"2024-09-20T06:21:28.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"tests/futility: Add test cases for unmodified RO\n\nTest the futility 'autoupdate' mode when the RO section is the same in\nboth the old and new firmware versions.\n\nRegardless of whether write protection (WP) is true or false, futility\nshould only update the inactive firmware (RWB).\n\nBUG=b:194910959\nTEST=manual on tentacruel.\nTEST=unit tests passed.\n\nChange-Id: I35f9017f891e12bee8aff121d1eed8a008fbe4ae\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5869471\nReviewed-by: Yu-Ping Wu \nTested-by: Yu-Ping Wu \nReviewed-by: Jeremy Bettis \nTested-by: Dennis Yeh \nCommit-Queue: Dennis Yeh ","shortMessageHtmlLink":"tests/futility: Add test cases for unmodified RO"}},{"before":"018b21da6fe7240067d6d0cbb54b45d025ab7436","after":"b870ca2cc8c5412c97289e32ca19f80a8fcec69b","ref":"refs/heads/firmware-android-brya-14505.782.B","pushedAt":"2024-09-18T20:18:48.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"cgptlib: Add helper function for finding pvmfw\n\nThis changes add a new function for finding pvmfw partition from disk.\nThis function will used by the following patches.\n\nBUG=b:354045389\nBUG=b:359340876\nTEST=Check if the contents matches with partition\nBRANCH=firmware-android-15949.B\n\n(cherry picked from commit 07270417d3824db7233b4a85cf2c8363744d873d)\n\nChange-Id: I4814c62a52cb2cdc0682964527d214a94f6375e3\nOriginal-Signed-off-by: Bartłomiej Grzesik \nOriginal-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5816953\nOriginal-Reviewed-by: Konrad Adamczyk \nOriginal-Reviewed-by: Jakub Czapiga \nGitOrigin-RevId: 07270417d3824db7233b4a85cf2c8363744d873d\nCr-Build-Id: 8736464299321650529\nCr-Build-Url: https://cr-buildbucket.appspot.com/build/8736464299321650529\nCopybot-Job-Name: android-main-fw-brya-vboot_reference-copybot-downstream\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5867942\nReviewed-by: Eran Mitrani \nCommit-Queue: Eran Mitrani \nTested-by: ChromeOS Prod (Robot) ","shortMessageHtmlLink":"cgptlib: Add helper function for finding pvmfw"}},{"before":"0eafca74bb101d285e3ec08b6abd1059c0aa93e3","after":"c6262a713f8681a289af65488b5824add06ae085","ref":"refs/heads/firmware-android-nissa-15217.630.B","pushedAt":"2024-09-18T14:20:27.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"avb: Add pvmfw verification and loading to memory.\n\nThis change extends avb to load and verify pvmfw into provided buffer.\n\nBUG=b:354045389\nBUG=b:359340876\nTEST=Check if the contents of the memory matches\nBRANCH=firmware-android-15949.B\n\n(cherry picked from commit 5a174c68cd1a610aff5d470cc7261dbb5af2ee27)\n\nCq-Depend: chromium:5816953\nCq-Depend: chromium:5816954\nChange-Id: Id60362b83b91b3ec80153c557dc57266f9801903\nOriginal-Signed-off-by: Bartłomiej Grzesik \nOriginal-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5816955\nOriginal-Reviewed-by: Konrad Adamczyk \nOriginal-Reviewed-by: Jakub Czapiga \nGitOrigin-RevId: 5a174c68cd1a610aff5d470cc7261dbb5af2ee27\nCr-Build-Id: 8736464299279668305\nCr-Build-Url: https://cr-buildbucket.appspot.com/build/8736464299279668305\nCopybot-Job-Name: android-main-fw-nissa-vboot_reference-copybot-downstream\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5867940\nTested-by: ChromeOS Prod (Robot) \nReviewed-by: Łukasz Majczak \nCommit-Queue: Łukasz Majczak ","shortMessageHtmlLink":"avb: Add pvmfw verification and loading to memory."}},{"before":null,"after":"2190262902561e5e57b088235f6e7302003f1c3b","ref":"refs/heads/firmware-R130-16032.B","pushedAt":"2024-09-17T20:20:33.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"futility/file_type_bios.c: Skip keyblock checks if magic is invalid\n\nThe following warning messages appear every time upstream coreboot is\nbuilt with Vboot enabled:\n\n```\nWARNING: prepare_slot: VBLOCK_A keyblock is invalid.\nWARNING: prepare_slot: VBLOCK_B keyblock is invalid.\n```\n\nThis patch ensures that the warnings are not printed, by skipping checks\nif the keyblock magic is invalid. A new keyblock will be generated\nwithout extraneous warnings.\n\nChange-Id: If8e653036b4ca1d10f28bc3bab105b38b152edcd\nSigned-off-by: Michał Kopeć \nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5682443\nTested-by: Julius Werner \nReviewed-by: Yu-Ping Wu \nCommit-Queue: Julius Werner ","shortMessageHtmlLink":"futility/file_type_bios.c: Skip keyblock checks if magic is invalid"}},{"before":null,"after":"a113946f11ddd7e88c9316bd1654d929eacccca5","ref":"refs/heads/firmware-firmware-android-brya-recipe-test-14505.782.B","pushedAt":"2024-09-17T20:20:33.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"futility: updater: add new quirk 'extra_retries'\n\nIn early bring up, some devices may have problem when flashrom is\nreading or writing to the system flash. To unblock dogfood process,\nwe want to have a special quirk to retry flashing.\n\nBUG=b:213706510\nTEST=make; build and run test\nBRANCH=None\n\nChange-Id: I58788f620fb32f7c886d1e5638f4a3605ea77953\nSigned-off-by: Hung-Te Lin \nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3452846\nReviewed-by: YH Lin \nCommit-Queue: YH Lin \nReviewed-by: Yu-Ping Wu \n(cherry picked from commit 707b839fadfd600af4300bc451946f8e8ccf840e)\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/3906634\nCommit-Queue: Nick Vaccaro \nTested-by: Nick Vaccaro ","shortMessageHtmlLink":"futility: updater: add new quirk 'extra_retries'"}},{"before":null,"after":"2190262902561e5e57b088235f6e7302003f1c3b","ref":"refs/heads/release-R130-16033.B","pushedAt":"2024-09-16T16:21:00.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"futility/file_type_bios.c: Skip keyblock checks if magic is invalid\n\nThe following warning messages appear every time upstream coreboot is\nbuilt with Vboot enabled:\n\n```\nWARNING: prepare_slot: VBLOCK_A keyblock is invalid.\nWARNING: prepare_slot: VBLOCK_B keyblock is invalid.\n```\n\nThis patch ensures that the warnings are not printed, by skipping checks\nif the keyblock magic is invalid. A new keyblock will be generated\nwithout extraneous warnings.\n\nChange-Id: If8e653036b4ca1d10f28bc3bab105b38b152edcd\nSigned-off-by: Michał Kopeć \nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5682443\nTested-by: Julius Werner \nReviewed-by: Yu-Ping Wu \nCommit-Queue: Julius Werner ","shortMessageHtmlLink":"futility/file_type_bios.c: Skip keyblock checks if magic is invalid"}},{"before":"2772b574c8bc6e53adddc1f4faf9513242e74d13","after":"5a174c68cd1a610aff5d470cc7261dbb5af2ee27","ref":"refs/heads/firmware-android-15949.B","pushedAt":"2024-09-16T12:19:15.000Z","pushType":"push","commitsCount":4,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"avb: Add pvmfw verification and loading to memory.\n\nThis change extends avb to load and verify pvmfw into provided buffer.\n\nBUG=b:354045389\nBUG=b:359340876\nTEST=Check if the contents of the memory matches\nBRANCH=firmware-android-15949.B\n\nCq-Depend: chromium:5816953\nCq-Depend: chromium:5816954\nChange-Id: Id60362b83b91b3ec80153c557dc57266f9801903\nSigned-off-by: Bartłomiej Grzesik \nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5816955\nReviewed-by: Konrad Adamczyk \nReviewed-by: Jakub Czapiga ","shortMessageHtmlLink":"avb: Add pvmfw verification and loading to memory."}},{"before":"f5924321909da88879e053a61a5b823de8858c44","after":"2190262902561e5e57b088235f6e7302003f1c3b","ref":"refs/heads/main","pushedAt":"2024-09-13T00:19:43.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"futility/file_type_bios.c: Skip keyblock checks if magic is invalid\n\nThe following warning messages appear every time upstream coreboot is\nbuilt with Vboot enabled:\n\n```\nWARNING: prepare_slot: VBLOCK_A keyblock is invalid.\nWARNING: prepare_slot: VBLOCK_B keyblock is invalid.\n```\n\nThis patch ensures that the warnings are not printed, by skipping checks\nif the keyblock magic is invalid. A new keyblock will be generated\nwithout extraneous warnings.\n\nChange-Id: If8e653036b4ca1d10f28bc3bab105b38b152edcd\nSigned-off-by: Michał Kopeć \nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5682443\nTested-by: Julius Werner \nReviewed-by: Yu-Ping Wu \nCommit-Queue: Julius Werner ","shortMessageHtmlLink":"futility/file_type_bios.c: Skip keyblock checks if magic is invalid"}},{"before":"f8bfa28ca4624adc6d05d2ab5f49a24cb17e2cfa","after":"2772b574c8bc6e53adddc1f4faf9513242e74d13","ref":"refs/heads/firmware-android-15949.B","pushedAt":"2024-09-06T22:19:23.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"Fix partition type check for miniOS B\n\n.. this should use partition 10 rather than 9.\n\nBUG=b:363466852\nTEST=none\nBRANCH=None\n\n(cherry picked from commit f5924321909da88879e053a61a5b823de8858c44)\n\nChange-Id: I15364511f982c9410af0a5e3397655da4fd49d4c\nOriginal-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5837192\nOriginal-Tested-by: George Engelbrecht \nOriginal-Auto-Submit: Jae Hoon Kim \nOriginal-Commit-Queue: Jae Hoon Kim \nOriginal-Commit-Queue: George Engelbrecht \nOriginal-Tested-by: Jae Hoon Kim \nOriginal-Commit-Queue: Benjamin Shai \nOriginal-Reviewed-by: Benjamin Shai \nOriginal-Reviewed-by: George Engelbrecht \nGitOrigin-RevId: f5924321909da88879e053a61a5b823de8858c44\nCr-Build-Id: 8737551462803103057\nCr-Build-Url: https://cr-buildbucket.appspot.com/build/8737551462803103057\nCopybot-Job-Name: android-main-vboot_reference-copybot-downstream\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5841358\nReviewed-by: George Engelbrecht \nTested-by: Jae Hoon Kim \nTested-by: ChromeOS Prod (Robot) \nCommit-Queue: Jae Hoon Kim ","shortMessageHtmlLink":"Fix partition type check for miniOS B"}},{"before":"88c49e9308e819e5151aa24c8b0f1605ba1d58c0","after":"f8bfa28ca4624adc6d05d2ab5f49a24cb17e2cfa","ref":"refs/heads/firmware-android-15949.B","pushedAt":"2024-09-06T06:18:15.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"signing: miniOS signing in docker.\n\nFor some reason, lsblk reports null partition types in docker, even in\nprivileged\n(https://forums.docker.com/t/why-does-lsblk-report-partition-as-null-from-within-a-docker-container/139393).\nPrefer cgpt for checking the partition type, which appears to work, and\nfallback on lsblk (because the legacy signers only have that).\n\nThis commit also removed the check for the private key on disk because\nthe key lives in Cloud KMS, adds a newline to an info statement that\nwas getting concatenated to the previous log message, and unrolls the\nloop over all loop devices (opting to just explicitly check the two\nminios loop devices).\n\nBUG=b:363466852\nBRANCH=None\nTEST=manual\n\n(cherry picked from commit dc5102f2f0614ec62924fa69cc1e364a9b73e391)\n\nChange-Id: I044c626dfac5ae7115b9f6b7e65e8303595544fb\nOriginal-Signed-off-by: Benjamin Shai \nOriginal-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5833916\nOriginal-Reviewed-by: Jae Hoon Kim \nOriginal-Reviewed-by: George Engelbrecht \nGitOrigin-RevId: dc5102f2f0614ec62924fa69cc1e364a9b73e391\nCr-Build-Id: 8737642059976117361\nCr-Build-Url: https://cr-buildbucket.appspot.com/build/8737642059976117361\nCopybot-Job-Name: android-main-vboot_reference-copybot-downstream\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5837673\nCommit-Queue: Yu-Ping Wu \nTested-by: ChromeOS Prod (Robot) \nReviewed-by: Yu-Ping Wu ","shortMessageHtmlLink":"signing: miniOS signing in docker."}},{"before":"83f845b3b5dadec27307cb772490d0203d42a78e","after":"f5924321909da88879e053a61a5b823de8858c44","ref":"refs/heads/main","pushedAt":"2024-09-06T00:20:12.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"Fix partition type check for miniOS B\n\n.. this should use partition 10 rather than 9.\n\nBUG=b:363466852\nTEST=none\nBRANCH=None\n\nChange-Id: I15364511f982c9410af0a5e3397655da4fd49d4c\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5837192\nTested-by: George Engelbrecht \nAuto-Submit: Jae Hoon Kim \nCommit-Queue: Jae Hoon Kim \nCommit-Queue: George Engelbrecht \nTested-by: Jae Hoon Kim \nCommit-Queue: Benjamin Shai \nReviewed-by: Benjamin Shai \nReviewed-by: George Engelbrecht ","shortMessageHtmlLink":"Fix partition type check for miniOS B"}},{"before":"23f25e3e140d591fb85b59acf95a99681abde8b5","after":"018b21da6fe7240067d6d0cbb54b45d025ab7436","ref":"refs/heads/firmware-android-brya-14505.782.B","pushedAt":"2024-09-05T20:19:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"cgptlib: Fix problem with finding partition\n\nFunction GptFindOffsetByName() finds partition based on\nname parameter, which is encoded as USC-2. It uses\n2 bytes per character, so memcmp() which is used for\ncomparison should use name length multiplied by 2.\n\nBUG=None\nTEST=None\nBRANCH=firmware-android-15949.B\n\n(cherry picked from commit 2114c7c7774ee374fad11995dcb2086537db4424)\n\nChange-Id: Ide316e92fb342237deea436b3e87ab82f1efae33\nOriginal-Signed-off-by: Grzegorz Bernacki \nOriginal-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5828869\nOriginal-Reviewed-by: Jan Dąbroś \nOriginal-Reviewed-by: Yu-Ping Wu \nGitOrigin-RevId: 2114c7c7774ee374fad11995dcb2086537db4424\nCr-Build-Id: 8737642059787759697\nCr-Build-Url: https://cr-buildbucket.appspot.com/build/8737642059787759697\nCopybot-Job-Name: android-main-fw-brya-vboot_reference-copybot-downstream\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5823076\nTested-by: ChromeOS Prod (Robot) \nCommit-Queue: Eran Mitrani \nTested-by: Eran Mitrani \nTested-by: Grzegorz Bernacki \nReviewed-by: Jonathon Murphy ","shortMessageHtmlLink":"cgptlib: Fix problem with finding partition"}},{"before":"dc5102f2f0614ec62924fa69cc1e364a9b73e391","after":"83f845b3b5dadec27307cb772490d0203d42a78e","ref":"refs/heads/main","pushedAt":"2024-09-05T20:19:24.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"signing: clean up owners\n\nRemove googlers no longer working here and add bshai@.\n\nBUG=None\nBRANCH=None\nTEST=None\n\nChange-Id: I2195ceea2e94a7659784453e60a46099d61b183d\nSigned-off-by: Benjamin Shai \nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5840434\nReviewed-by: George Engelbrecht \nCommit-Queue: George Engelbrecht \nTested-by: George Engelbrecht ","shortMessageHtmlLink":"signing: clean up owners"}},{"before":null,"after":"4b12d392e5b12de29c582df4e717b1228e9f1594","ref":"refs/heads/stabilize-15964.42.B","pushedAt":"2024-09-05T00:22:06.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"scripts: Add a script to convert a vbprivk to a PEM\n\nThis script allows converting a `vbprivk` file into a PEM file that can\nbe consumed by openssl.\n\nBUG=b:349468704\nBRANCH=none\nTEST=./scripts/keygeneration/vbprivk_to_pem.sh < tests/devkeys/kernel_subkey.vbprivk | $HOME/android/prebuilts/build-tools/linux-x86/bin/openssl pkey -pubout\n\nChange-Id: I80d4a7187698bbcfcbe02c3b667bc89227e498e4\nSigned-off-by: Raul E Rangel \nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5715316\nReviewed-by: Julius Werner \nCommit-Queue: Julius Werner ","shortMessageHtmlLink":"scripts: Add a script to convert a vbprivk to a PEM"}},{"before":"5324845656c2c7a688e8d0eed8b4f9c747706c96","after":"0030800ea14fe36194ad115a74e629f2bbeb44c6","ref":"refs/heads/firmware-android-dedede-13606.653.B","pushedAt":"2024-09-04T14:19:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"cgptlib: Fix problem with finding partition\n\nFunction GptFindOffsetByName() finds partition based on\nname parameter, which is encoded as USC-2. It uses\n2 bytes per character, so memcmp() which is used for\ncomparison should use name length multiplied by 2.\n\nBUG=None\nTEST=None\nBRANCH=firmware-android-15949.B\n\n(cherry picked from commit 2114c7c7774ee374fad11995dcb2086537db4424)\n\nChange-Id: Ide316e92fb342237deea436b3e87ab82f1efae33\nOriginal-Signed-off-by: Grzegorz Bernacki \nOriginal-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5828869\nOriginal-Reviewed-by: Jan Dąbroś \nOriginal-Reviewed-by: Yu-Ping Wu \nGitOrigin-RevId: 2114c7c7774ee374fad11995dcb2086537db4424\nCr-Build-Id: 8737732657242228177\nCr-Build-Url: https://cr-buildbucket.appspot.com/build/8737732657242228177\nCopybot-Job-Name: android-main-fw-dedede-vboot_reference-copybot-downstream\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5830498\nCommit-Queue: Kornel Dulęba \nReviewed-by: Jonathon Murphy \nTested-by: ChromeOS Prod (Robot) ","shortMessageHtmlLink":"cgptlib: Fix problem with finding partition"}},{"before":"8684b64f5cc75c5eeaa64c9084bf97dae01a89fc","after":"0eafca74bb101d285e3ec08b6abd1059c0aa93e3","ref":"refs/heads/firmware-android-nissa-15217.630.B","pushedAt":"2024-09-04T14:19:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"cgptlib: Fix problem with finding partition\n\nFunction GptFindOffsetByName() finds partition based on\nname parameter, which is encoded as USC-2. It uses\n2 bytes per character, so memcmp() which is used for\ncomparison should use name length multiplied by 2.\n\nBUG=None\nTEST=None\nBRANCH=firmware-android-15949.B\n\n(cherry picked from commit 2114c7c7774ee374fad11995dcb2086537db4424)\n\nChange-Id: Ide316e92fb342237deea436b3e87ab82f1efae33\nOriginal-Signed-off-by: Grzegorz Bernacki \nOriginal-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5828869\nOriginal-Reviewed-by: Jan Dąbroś \nOriginal-Reviewed-by: Yu-Ping Wu \nGitOrigin-RevId: 2114c7c7774ee374fad11995dcb2086537db4424\nCr-Build-Id: 8737732656835765585\nCr-Build-Url: https://cr-buildbucket.appspot.com/build/8737732656835765585\nCopybot-Job-Name: android-main-fw-nissa-vboot_reference-copybot-downstream\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5823078\nReviewed-by: Patryk Busse \nReviewed-by: Jonathon Murphy \nCommit-Queue: Łukasz Majczak \nTested-by: ChromeOS Prod (Robot) \nReviewed-by: Łukasz Majczak ","shortMessageHtmlLink":"cgptlib: Fix problem with finding partition"}},{"before":"16e6aa8907fcfeaebfb479110abe1317b9111b2a","after":"dc5102f2f0614ec62924fa69cc1e364a9b73e391","ref":"refs/heads/main","pushedAt":"2024-09-04T14:19:53.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"signing: miniOS signing in docker.\n\nFor some reason, lsblk reports null partition types in docker, even in\nprivileged\n(https://forums.docker.com/t/why-does-lsblk-report-partition-as-null-from-within-a-docker-container/139393).\nPrefer cgpt for checking the partition type, which appears to work, and\nfallback on lsblk (because the legacy signers only have that).\n\nThis commit also removed the check for the private key on disk because\nthe key lives in Cloud KMS, adds a newline to an info statement that\nwas getting concatenated to the previous log message, and unrolls the\nloop over all loop devices (opting to just explicitly check the two\nminios loop devices).\n\nBUG=b:363466852\nBRANCH=None\nTEST=manual\n\nChange-Id: I044c626dfac5ae7115b9f6b7e65e8303595544fb\nSigned-off-by: Benjamin Shai \nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5833916\nReviewed-by: Jae Hoon Kim \nReviewed-by: George Engelbrecht ","shortMessageHtmlLink":"signing: miniOS signing in docker."}},{"before":"303aa543274f09fb300ad29de54e7a63a4d4def1","after":"85927d66d0300d6b88ca5876c2d055f0e312122b","ref":"refs/heads/firmware-android-corsola-15194.225.B","pushedAt":"2024-09-04T10:20:22.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"cgptlib: Fix problem with finding partition\n\nFunction GptFindOffsetByName() finds partition based on\nname parameter, which is encoded as USC-2. It uses\n2 bytes per character, so memcmp() which is used for\ncomparison should use name length multiplied by 2.\n\nBUG=None\nTEST=None\nBRANCH=firmware-android-15949.B\n\n(cherry picked from commit 2114c7c7774ee374fad11995dcb2086537db4424)\n\nChange-Id: Ide316e92fb342237deea436b3e87ab82f1efae33\nOriginal-Signed-off-by: Grzegorz Bernacki \nOriginal-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5828869\nOriginal-Reviewed-by: Jan Dąbroś \nOriginal-Reviewed-by: Yu-Ping Wu \nGitOrigin-RevId: 2114c7c7774ee374fad11995dcb2086537db4424\nCr-Build-Id: 8737742626229598705\nCr-Build-Url: https://cr-buildbucket.appspot.com/build/8737742626229598705\nCopybot-Job-Name: android-main-fw-corsola-vboot_reference-copybot-downstream\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5823077\nReviewed-by: Yu-Ping Wu \nTested-by: ChromeOS Prod (Robot) \nCommit-Queue: Yu-Ping Wu ","shortMessageHtmlLink":"cgptlib: Fix problem with finding partition"}},{"before":"2114c7c7774ee374fad11995dcb2086537db4424","after":"88c49e9308e819e5151aa24c8b0f1605ba1d58c0","ref":"refs/heads/firmware-android-15949.B","pushedAt":"2024-09-04T06:18:14.000Z","pushType":"push","commitsCount":8,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"futility: updater: Provide default DUT properties for emulation\n\nWhen --emulate is specified, all the dut_get_property() calls would\nfail. The option --sys_props exists to allow overriding the DUT\nproperties. However, it's bothersome to specify it every time we want to\nrun the updater with emulation.\n\nTherefore, provide default DUT properties for emulation. The active\nfirmware slot is set to A. The TPM firmware version is set to 0x10001\n(to pass TPM key compatibility check). The platform version is set to 0.\nBoth hardware and software write protect states are assumed to be\ndisabled for convenience.\n\nSome of the --sys_props arguments in test_update.sh are simplified or\nomitted.\n\nBUG=none\nTEST=make runfutiltests -j\nTEST=futility update --emulate image.bin -i new.bin --mode=factory\nBRANCH=none\n\n(cherry picked from commit 16e6aa8907fcfeaebfb479110abe1317b9111b2a)\n\nChange-Id: I25202ad05a5c2e671b416c42951be8cdafee5689\nOriginal-Signed-off-by: Yu-Ping Wu \nOriginal-Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5807011\nOriginal-Reviewed-by: Hung-Te Lin \nGitOrigin-RevId: 16e6aa8907fcfeaebfb479110abe1317b9111b2a\nCr-Build-Id: 8737823253384683697\nCr-Build-Url: https://cr-buildbucket.appspot.com/build/8737823253384683697\nCopybot-Job-Name: android-main-vboot_reference-copybot-downstream\nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5832136\nReviewed-by: Yu-Ping Wu \nCommit-Queue: Yu-Ping Wu \nTested-by: ChromeOS Prod (Robot) ","shortMessageHtmlLink":"futility: updater: Provide default DUT properties for emulation"}},{"before":"c99c3ad7aa5cc137b73246b9e7f185b6afd91904","after":"2114c7c7774ee374fad11995dcb2086537db4424","ref":"refs/heads/firmware-android-15949.B","pushedAt":"2024-09-02T16:19:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"cgptlib: Fix problem with finding partition\n\nFunction GptFindOffsetByName() finds partition based on\nname parameter, which is encoded as USC-2. It uses\n2 bytes per character, so memcmp() which is used for\ncomparison should use name length multiplied by 2.\n\nBUG=None\nTEST=None\nBRANCH=firmware-android-15949.B\n\nChange-Id: Ide316e92fb342237deea436b3e87ab82f1efae33\nSigned-off-by: Grzegorz Bernacki \nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5828869\nReviewed-by: Jan Dąbroś \nReviewed-by: Yu-Ping Wu ","shortMessageHtmlLink":"cgptlib: Fix problem with finding partition"}},{"before":"7e2828a1bacfbcbe3480378bf5482004c3901698","after":"16e6aa8907fcfeaebfb479110abe1317b9111b2a","ref":"refs/heads/main","pushedAt":"2024-09-02T10:19:14.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"coreboot-org-bot","name":"coreboot.org bot","path":"/coreboot-org-bot","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/46246920?s=80&v=4"},"commit":{"message":"futility: updater: Provide default DUT properties for emulation\n\nWhen --emulate is specified, all the dut_get_property() calls would\nfail. The option --sys_props exists to allow overriding the DUT\nproperties. However, it's bothersome to specify it every time we want to\nrun the updater with emulation.\n\nTherefore, provide default DUT properties for emulation. The active\nfirmware slot is set to A. The TPM firmware version is set to 0x10001\n(to pass TPM key compatibility check). The platform version is set to 0.\nBoth hardware and software write protect states are assumed to be\ndisabled for convenience.\n\nSome of the --sys_props arguments in test_update.sh are simplified or\nomitted.\n\nBUG=none\nTEST=make runfutiltests -j\nTEST=futility update --emulate image.bin -i new.bin --mode=factory\nBRANCH=none\n\nChange-Id: I25202ad05a5c2e671b416c42951be8cdafee5689\nSigned-off-by: Yu-Ping Wu \nReviewed-on: https://chromium-review.googlesource.com/c/chromiumos/platform/vboot_reference/+/5807011\nReviewed-by: Hung-Te Lin ","shortMessageHtmlLink":"futility: updater: Provide default DUT properties for emulation"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yNFQxMjoxOTozNi4wMDAwMDBazwAAAAS_HNj9","startCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0yNFQxMjoxOTozNi4wMDAwMDBazwAAAAS_HNj9","endCursor":"Y3Vyc29yOnYyOpK7MjAyNC0wOS0wMlQxMDoxOToxNC4wMDAwMDBazwAAAASqdR4Z"}},"title":"Activity · coreboot/vboot"}