Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow sending message by MessagingServiceSid for TwilioSmsSenderServiceProvider #76

Open
youb93 opened this issue Sep 11, 2023 · 0 comments

Comments

@youb93
Copy link

youb93 commented Sep 11, 2023

Today we can send message with a phoneNumber/orce MessageServiceId but the new PhoneNumber(twilioPhoneNumber) is ambiguous as we can see inside keycloak-phone-provider/keycloak-sms-provider-twilio/src/main/java/cc/coopersoft/keycloak/phone/providers/sender/TwilioSmsSenderServiceProvider.java

public void sendMessage(String phoneNumber, String message) throws MessageSendException { Message msg = Message.creator( new PhoneNumber(phoneNumber), new PhoneNumber(twilioPhoneNumber), message).create();

Maybe we can think about this feature : https://www.twilio.com/docs/messaging/services#:~:text=Send%20a%20message%20with%20a%20Messaging%20Service,-If%20you%20use&text=However%2C%20instead%20of%20including%20a,based%20on%20your%20service's%20configuration
Which allows to send a message with a configured messaging service.

and think about changing naming of phoneNumber for something more generic
or think about handling messaging service id in an other way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant