Pin watchdog to 4.0.2 #5335
Merged
Pin watchdog to 4.0.2 #5335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Watchdog 5.0.0 was recently released. This update causes Werkzeug to reload the Django server much more frequently than desired (causing the local docker development build to barely load).
|
Have you reported the issue upstream? Would it be worth pinning it in werkzeug instead? |
browniebroke
approved these changes
Sep 3, 2024
|
I think this has now been fixed in werkzeug 3.0.5 so I'll remove this pin when I merge the upgrade: pallets/werkzeug#2945 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Watchdog 5.0.0 was recently released. This update causes Werkzeug to reload the Django server much more frequently than desired (causing the local docker development build to barely load).
Description
Checklist:
Rationale
Without this change, playing around with the local docker development build consistently fails with ECONNRESET due to page loads triggering inotify events and therefore django server reboots
I've not tried to reproduce this issue on other environments, but this is the case on my M3 Mac.