Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ownership for /start-flower script in production Dockerfile #4603

Merged
merged 1 commit into from
Sep 27, 2023

Conversation

SukiCZ
Copy link
Contributor

@SukiCZ SukiCZ commented Sep 27, 2023

Description

Fixing a bug which seems like a missing a small typo. I needed to apply these changes to production env to be able to start Flower

Checklist:

  • I've made sure that tests are updated accordingly (especially if adding or updating a template option)
  • I've updated the documentation or confirm that my change doesn't require any updates

The documentation doesn't need to be updated but I don't know how to test such change (it works on production tho)

Rationale

Fix #4602

This project is optionally shipped with Flower which doesn't run in production without this change. This seems like a small typo as other files are changing ownership to Django user. I hope I'm not missing something.

Thanks for a great project BTW ❤️

EDIT: I could add some small test suite for Flower if requested (just need more time) 🤞🏿

Copy link
Member

@browniebroke browniebroke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Wondering how it's been broken all this time. Oh well...

@browniebroke browniebroke changed the title Fix ownership for /start-flower script in production Dockerfile. Fixes: #4602 Fix ownership for /start-flower script in production Dockerfile Sep 27, 2023
@browniebroke
Copy link
Member

Regarding testing, although I wish I had a better answer, there isn't much we can do right now, so don't worry about it.

@browniebroke browniebroke merged commit 3126d2e into cookiecutter:master Sep 27, 2023
@SukiCZ SukiCZ deleted the fix/4602 branch November 3, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flower on production raises Permission denied
2 participants