-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add locked state to cards #431
Conversation
size-limit report 📦
|
Hey @anoblet Good start. What you showed above would be difficult for users as they can not see the title of the course, so they will just see a list of CTAs and the same microcopy. Original intention was to swap the excerpt. What you showed however could work on hover. Something like this? I would probably keep the CTA to take the user to the course. As some have promo videos and they may want to find out more about the course. They can always click this piece on the course page to go to pricing. |
@anoblet if you are struggling to get hover to work properly, then we can just try originally intended version. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is overcomplicated. Also such message should not be hardcoded. It was supposed to replace regular course description.
"All-Access" product name always hyphenated, right? Unsure: do we need to repeat CXL? I mean who else's All-Access are we selling? |
BRAAAANDDDDDD!!!! I agree and am definitely up for removing repetition here, its redundant. Especially in a tooltip which is latest incarnation proposed by @pawelkmpt would propose a slight tweak to the tool tip copy as it conflicts with the CTA. Purchase to view >> View course
|
Made it hardcoded as @heshfekry suggested message different than we currently use but provided override possibility. |
5b3241d
to
ed44713
Compare
b3015dd
to
b22795a
Compare
https://app.clickup.com/t/86b1nztyh
Course card:
Light card: