Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cxl-ui): fix course card layout issues #337

Merged
merged 2 commits into from
Sep 29, 2023

Conversation

freudFlintstone
Copy link

@github-actions
Copy link

github-actions bot commented Sep 26, 2023

size-limit report 📦

Path Size
packages/cxl-ui/pkg/dist-web/cxl-ui.js 63.29 KB (+0.1% 🔺)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js 11.87 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js 27.55 KB (0%)
packages/cxl-ui/pkg/dist-web/vendor.js 135.58 KB (0%)
packages/cxl-ui/pkg/dist-web/cxl-ui-jwplayer.js, packages/cxl-ui/pkg/dist-web/cxl-ui-playbooks.js, packages/cxl-ui/pkg/dist-web/cxl-ui.js, packages/cxl-ui/pkg/dist-web/manifest.js, packages/cxl-ui/pkg/dist-web/unresolved.js, packages/cxl-ui/pkg/dist-web/vendor.js 239.43 KB (+0.03% 🔺)

@freudFlintstone freudFlintstone force-pushed the raphael/fix/institute/cards-upgrade branch 3 times, most recently from 8f25028 to d48429e Compare September 26, 2023 21:43
@freudFlintstone freudFlintstone changed the title fix(cxl-ui): fix course card layout fix(cxl-ui): fix course card layout issues Sep 26, 2023
@freudFlintstone freudFlintstone marked this pull request as ready for review September 26, 2023 21:44
@freudFlintstone freudFlintstone self-assigned this Sep 26, 2023
@freudFlintstone freudFlintstone force-pushed the raphael/fix/institute/cards-upgrade branch from d48429e to a4520ae Compare September 27, 2023 18:28
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the standard use for the tags slot has changed. To save space and correctly clip overflowing text, a single span element should be used with [slot=tags], containing all categories in a comma separated string.

Copy link

@pawelkmpt pawelkmpt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@freudFlintstone freudFlintstone force-pushed the raphael/fix/institute/cards-upgrade branch from a4520ae to 601f226 Compare September 28, 2023 15:02
@freudFlintstone
Copy link
Author

freudFlintstone commented Sep 28, 2023

This view is broken. Please check if just Storybook or bigger issue: https://deploy-preview-337--conversionxl-aybolit.netlify.app/?path=/story/cxl-ui-cxl-course-card--courses-dashboard-different-heights

It was , in fact, only about the storybook layout. But it does also mean we have to consider that when implementing the new institute home page grid.
This is after the fix:
image

@pawelkmpt pawelkmpt merged commit bd48908 into master Sep 29, 2023
4 checks passed
@pawelkmpt pawelkmpt deleted the raphael/fix/institute/cards-upgrade branch September 29, 2023 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants