-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(cxl-ui): fix course card layout issues #337
Conversation
size-limit report 📦
|
8f25028
to
d48429e
Compare
d48429e
to
a4520ae
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note the standard use for the tags slot has changed. To save space and correctly clip overflowing text, a single span element should be used with [slot=tags], containing all categories in a comma separated string.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This view is broken. Please check if just Storybook or bigger issue: https://deploy-preview-337--conversionxl-aybolit.netlify.app/?path=/story/cxl-ui-cxl-course-card--courses-dashboard-different-heights
a4520ae
to
601f226
Compare
It was , in fact, only about the storybook layout. But it does also mean we have to consider that when implementing the new institute home page grid. |
https://app.clickup.com/t/86ayagj21