You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The only way to view all the comments that are deferred, across all articles and all categories is to go to the Moderated tab of the All view /#/categories/all/moderated/deferred. That view is not performant when there are a lot of comments in the database. In the NYT production system, the /services/moderatedCounts/categories/all call that returns the commentIds for all the Moderated tabs eventually times out. So even though the product has a place to see all the deferred comments, it's not usable.
Expected Behavior
Ideally, the deferred tab of the All view renders all the deferred comments regardless of the scale of the comments in the database.
Actual Behavior
Since the deferred-all view is part of the Moderated-All tab (i.e. /#/categories/all/moderated), rendering that tab requires rendering the comments for all the tabs and that means fetching the commentIds for what could be millions and millions of comments.
Possible Fix
I'm not sure what the easiest fix is. We could change the /services/moderatedCounts/categories/all endpoint to return a paginated list of commentIds instead of all the ids. I'm not sure how big of a change that would be on the frontend.
Steps to Reproduce
Load a bunch of comments into your database
Go to the /#/categories/all/moderated/deferred page
Notice that the /services/moderatedCounts/categories/all endpoint returns every id in the database.
Context
Your Environment
Environment name and version (e.g. Chrome 39, etc):
Operating System and version (desktop or mobile):
The text was updated successfully, but these errors were encountered:
Context
The only way to view all the comments that are deferred, across all articles and all categories is to go to the Moderated tab of the All view
/#/categories/all/moderated/deferred
. That view is not performant when there are a lot of comments in the database. In the NYT production system, the/services/moderatedCounts/categories/all
call that returns the commentIds for all the Moderated tabs eventually times out. So even though the product has a place to see all the deferred comments, it's not usable.Expected Behavior
Ideally, the deferred tab of the All view renders all the deferred comments regardless of the scale of the comments in the database.
Actual Behavior
Since the deferred-all view is part of the Moderated-All tab (i.e.
/#/categories/all/moderated
), rendering that tab requires rendering the comments for all the tabs and that means fetching the commentIds for what could be millions and millions of comments.Possible Fix
I'm not sure what the easiest fix is. We could change the
/services/moderatedCounts/categories/all
endpoint to return a paginated list of commentIds instead of all the ids. I'm not sure how big of a change that would be on the frontend.Steps to Reproduce
/#/categories/all/moderated/deferred
page/services/moderatedCounts/categories/all
endpoint returns every id in the database.Context
Your Environment
The text was updated successfully, but these errors were encountered: