Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deferred All View doesn't scale #2

Open
ericagreene opened this issue Jul 12, 2017 · 0 comments
Open

Deferred All View doesn't scale #2

ericagreene opened this issue Jul 12, 2017 · 0 comments

Comments

@ericagreene
Copy link
Collaborator

Context

The only way to view all the comments that are deferred, across all articles and all categories is to go to the Moderated tab of the All view /#/categories/all/moderated/deferred. That view is not performant when there are a lot of comments in the database. In the NYT production system, the /services/moderatedCounts/categories/all call that returns the commentIds for all the Moderated tabs eventually times out. So even though the product has a place to see all the deferred comments, it's not usable.

Expected Behavior

Ideally, the deferred tab of the All view renders all the deferred comments regardless of the scale of the comments in the database.

Actual Behavior

Since the deferred-all view is part of the Moderated-All tab (i.e. /#/categories/all/moderated), rendering that tab requires rendering the comments for all the tabs and that means fetching the commentIds for what could be millions and millions of comments.

Possible Fix

I'm not sure what the easiest fix is. We could change the /services/moderatedCounts/categories/all endpoint to return a paginated list of commentIds instead of all the ids. I'm not sure how big of a change that would be on the frontend.

Steps to Reproduce

  1. Load a bunch of comments into your database
  2. Go to the /#/categories/all/moderated/deferred page
  3. Notice that the /services/moderatedCounts/categories/all endpoint returns every id in the database.

Context

Your Environment

  • Environment name and version (e.g. Chrome 39, etc):
  • Operating System and version (desktop or mobile):
RufusHamade referenced this issue in RufusHamade/conversationai-moderator-1 Sep 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant