hen consent is not given don't write cookies, extractDomain was doing so while trying to find the root.

Author: AaronColbyPrice

src/lib/pubcidHandler.js

@@ -157,11 +157,24 @@ export default class PubcidHandler {
      */
     deletePubcid({all = true} = {}) {
         const {name} = this.config;
-        if (all) {
-            deleteValue(COOKIE, name, this.getDomain(COOKIE));
-            deleteValue(LOCAL_STORAGE, name, this.getDomain(LOCAL_STORAGE));
-        } else {
-            deleteValue(this.typeEnabled, name);
+        if (all || this.typeEnabled == COOKIE) {
+            //Don't call getDomain as it may write out temp cookies so copy getDomain functionality here
+            if (this.config.cookieDomain !== undefined) {
+                deleteValue(COOKIE, name, this.config.cookieDomain);
+            } else if (this.cachedDomain !== undefined) {
+                deleteValue(COOKIE, name, this.cachedDomain);
+            } else {
+                //Just attempt to delete any cookie matching name and domain, don't care about success
+                const parts = this.getHostname().split('.');
+                for (let i = 0, len = parts.length; i < len; ++i) {
+                    const currDomain = parts.slice(i).join('.');
+                    deleteValue(COOKIE, name, currDomain);
+                }
+            }
+        }
+
+        if (all || this.typeEnabled == LOCAL_STORAGE) {
+            deleteValue(LOCAL_STORAGE, name, ''); //domain doesn't do anything for LOCAL_STORAGE
         }
     }
 
@@ -192,9 +205,18 @@ export default class PubcidHandler {
                 return this.cachedDomain
             }
             else {
-                this.cachedDomain = extractDomain(document.location.hostname);
+                this.cachedDomain = extractDomain(this.getHostname());
                 return this.cachedDomain;
             }
         }
     }
+
+    /**
+     * Wrapper for global value of document.location.hostname
+     * allows for easier unit testing to mock hostname.
+     * @returns {String} document.location.hostname
+     */
+    getHostname(){
+        return document.location.hostname;
+    }
 }

test/lib/pubcidHandler.spec.js

@@ -657,4 +657,86 @@ describe('PubcidHandler', ()=> {
             expect(domain).to.be.undefined;
         });
     });
+
+    describe('deletePubcid', ()=> {
+        let deleteStub;
+        before(()=>{
+            deleteStub = sinon.stub(storageUtils, 'deleteValue');
+            clearAll();
+        });
+
+        after(()=>{
+            deleteStub.restore();
+        })
+
+        beforeEach(() => {
+            deleteStub.resetHistory();
+        });
+
+        afterEach(() => {
+            clearAll();
+        });
+
+        it('delete Cookie From Config', ()=>{
+            const expectedDomain = 'hello.cookie';
+            const expectedPubcidName = '_foobar';
+            const options = {cookieDomain: expectedDomain, name: expectedPubcidName, type: COOKIE};
+            const handler = new PubcidHandler(options);
+            expect(deleteStub).to.have.not.been.called;
+            handler.deletePubcid({all: false});
+            expect(deleteStub).to.have.been.calledOnceWith(COOKIE, expectedPubcidName, expectedDomain)
+        });
+
+        it('delete Cookie From Cached Domain', ()=>{
+            const expectedDomain = undefined;
+            const cachedDomain = 'foobar.com';
+            const expectedPubcidName = '_foobar';
+            const options = {cookieDomain: expectedDomain, name: expectedPubcidName, type: COOKIE};
+            const handler = new PubcidHandler(options);
+            handler.cachedDomain = cachedDomain;
+            expect(deleteStub).to.have.not.been.called;
+            handler.deletePubcid({all: false});
+            expect(deleteStub).to.have.been.calledOnceWith(COOKIE, expectedPubcidName, cachedDomain)
+        });
+
+        it('delete Cookie From Hostname', ()=>{
+            const expectedDomain = undefined;
+            const expectedPubcidName = '_foobar';
+            const options = {cookieDomain: expectedDomain, name: expectedPubcidName, type: COOKIE};
+            const handler = new PubcidHandler(options);
+
+            let getHostnameStub = sinon.stub(handler, 'getHostname').returns("foo.bar.baz");
+
+            expect(deleteStub).to.have.not.been.called;
+            handler.deletePubcid({all: false});
+            sinon.assert.callCount(deleteStub, 3);
+            expect(deleteStub).to.have.been.calledWith(COOKIE, expectedPubcidName, "foo.bar.baz");
+            expect(deleteStub).to.have.been.calledWith(COOKIE, expectedPubcidName, "bar.baz");
+            expect(deleteStub).to.have.been.calledWith(COOKIE, expectedPubcidName, "baz");
+
+            getHostnameStub.restore();
+        });
+
+        it('delete Pubcid from Local Storage', ()=>{
+            const expectedDomain = "foobar.com";
+            const expectedPubcidName = '_foobar';
+            const options = {cookieDomain: expectedDomain, name: expectedPubcidName, type: LOCAL_STORAGE};
+            const handler = new PubcidHandler(options);
+            expect(deleteStub).to.have.not.been.called;
+            handler.deletePubcid({all: false});
+            expect(deleteStub).to.have.been.calledOnceWith(LOCAL_STORAGE, expectedPubcidName, '');
+        });
+
+        it('delete Pubcid from All', ()=>{
+            const expectedDomain = "foobar.com";
+            const expectedPubcidName = '_foobar';
+            const options = {cookieDomain: expectedDomain, name: expectedPubcidName, type: LOCAL_STORAGE};
+            const handler = new PubcidHandler(options);
+            expect(deleteStub).to.have.not.been.called;
+            handler.deletePubcid();
+            sinon.assert.callCount(deleteStub, 2);
+            expect(deleteStub).to.have.been.calledWith(COOKIE, expectedPubcidName, expectedDomain)
+            expect(deleteStub).to.have.been.calledWith(LOCAL_STORAGE, expectedPubcidName, '');
+        });
+    });
 });