-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Package.json is being ignore if part of the full path matches #253
Comments
This just bit me. I have |
Actually it turns out I had a layered issue on top of this one that is related but not quite the same: but also a too-greedy match being done. See bcoe/dotgitignore#7 |
Thinking of the possible fixes here: Option 1: Spawn and parse the output of Option 2: Re-implement / update the gitignore algorithm in JavaScript inside the dotgitignore library to match the one from git. For the purpose of standard-version, given that What do you think if we go with option 1 and rely on git to perform the check instead? |
This issue is fixed in absolute-version#1 Tested with [email protected] |
My package.json and package-lock.json are being ignored by https://github.com/conventional-changelog/standard-version when trying to bump the version, the reason is that the full path of my package.json contains some words or matches with some specification in
.gitignore
filelet's say I have this
and my project is in the following path
so this always evaluates to true:
I have posted something related in the PR #230
The text was updated successfully, but these errors were encountered: