You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So I'm wondering if it makes sense to add Breadcrumbs inside page such that when Page is given a breadcrumb prop, it uses Breadcrumbs and Breadcrumb internally like so:
The drawback I see is that it couples Breadcrumbs and Page and makes Page a bit more complex and fundamentally disrupts a nice composition model in userland.
That said, something like this:
isn't really attainable in userland without adding this prop to Page and significant UI/CSS hackery. Instead, one would end up with something like this out of the box:
So the question finally is: should we add this prop or not?
The text was updated successfully, but these errors were encountered:
So I'm wondering if it makes sense to add
Breadcrumbs
inside page such that whenPage
is given abreadcrumb
prop, it usesBreadcrumbs
andBreadcrumb
internally like so:The drawback I see is that it couples
Breadcrumbs
andPage
and makesPage
a bit more complex and fundamentally disrupts a nice composition model in userland.That said, something like this:
isn't really attainable in userland without adding this prop to Page and significant UI/CSS hackery. Instead, one would end up with something like this out of the box:
So the question finally is: should we add this prop or not?
The text was updated successfully, but these errors were encountered: