Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breadcrumb to Page #1150

Open
TejasQ opened this issue Jul 17, 2019 · 2 comments
Open

Add breadcrumb to Page #1150

TejasQ opened this issue Jul 17, 2019 · 2 comments
Assignees

Comments

@TejasQ
Copy link
Contributor

TejasQ commented Jul 17, 2019

So I'm wondering if it makes sense to add Breadcrumbs inside page such that when Page is given a breadcrumb prop, it uses Breadcrumbs and Breadcrumb internally like so:

<Page
  breadcrumb={
    [
      { label: "Start", to: "/" },
      { label: "Here", to: "/here" }
    ]
  }
/>

The drawback I see is that it couples Breadcrumbs and Page and makes Page a bit more complex and fundamentally disrupts a nice composition model in userland.

That said, something like this:

image

isn't really attainable in userland without adding this prop to Page and significant UI/CSS hackery. Instead, one would end up with something like this out of the box:

image

So the question finally is: should we add this prop or not?

@TejasQ
Copy link
Contributor Author

TejasQ commented Jul 17, 2019

image

@TejasQ
Copy link
Contributor Author

TejasQ commented Jul 17, 2019

Great. Let's do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants