Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DynamicAssertion breaks Builder::sign_async on tokio #882

Closed
duggaraju opened this issue Jan 24, 2025 · 3 comments
Closed

DynamicAssertion breaks Builder::sign_async on tokio #882

duggaraju opened this issue Jan 24, 2025 · 3 comments
Assignees
Labels
accepted bug Something isn't working status: done

Comments

@duggaraju
Copy link
Contributor

Since DynamicAssertion doesn't implement Send, ManifestDefintion and hence Builder are no longer Send. That means calling Builder::sign_async from an async runtime that requires send (e.g: tokio) would fail.

@gpeacock gpeacock added bug Something isn't working accepted labels Feb 15, 2025
@gpeacock gpeacock self-assigned this Feb 15, 2025
@github-jira-sync-bot
Copy link

✅ Jira issue https://jira.corp.adobe.com/browse/CAI-7678 is successfully created for this GitHub issue.

@gpeacock
Copy link
Collaborator

We have added an AsyncDynamicAssertion with Send support now.

@duggaraju
Copy link
Contributor Author

@gpeacock looking at the latest code in the master branch I still see the AsyncDynamicAssertion only implements Sync and not Send

pub trait AsyncDynamicAssertion: Sync {

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accepted bug Something isn't working status: done
Projects
None yet
Development

No branches or pull requests

3 participants