Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leaking memory allocated by libsubid #1558

Open
debarshiray opened this issue Sep 30, 2024 · 0 comments
Open

Leaking memory allocated by libsubid #1558

debarshiray opened this issue Sep 30, 2024 · 0 comments
Labels
1. Bug Something isn't working

Comments

@debarshiray
Copy link
Member

debarshiray commented Sep 30, 2024 •
edited
Loading

The array of struct subid_range allocated by subid_get_gid_ranges and subid_get_uid_ranges needs to be freed by the libsubid API user. Currently, these are being leaked from inside validateSubIDRanges(). This is a fallout from:
ca8007c

Shadow 4.16.0 changed the library's soname to libsubid.so.5.0.0 and introduced subid_free() for this. Earlier, the convention was to use free(3). See:
shadow-maint/shadow@0217516
shadow-maint/shadow#1019
shadow-maint/shadow#1018
@debarshiray debarshiray added the 1. Bug Something isn't working label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
1. Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@debarshiray