Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

composefs should inline recommended file sizes #2091

Open
cgwalters opened this issue Sep 11, 2024 · 2 comments
Open

composefs should inline recommended file sizes #2091

cgwalters opened this issue Sep 11, 2024 · 2 comments
Labels
area/composefs composefs related changes

Comments

@cgwalters
Copy link
Contributor

In composefs we support (and effectively recommend) inlining <= 64 byte files - it can especially be useful for zero sized files which are not uncommon.

Let's change what is done here to do that by default. One notable thing is this decision changes the fsverity digest of the composefs.

For example,

$ podman run --pull=newer --rm -ti quay.io/centos-bootc/centos-bootc:stream9 bash
# find /etc -type f -size -65c | wc -l
493  # out of 1337
# find /usr -type f -size -65c | wc -l
572  # out of 26376
#

So just about 3% of files, but far from nothing.

Today ostree doesn't do this because basically composefs is just glued onto the side of its already extant on-disk representation which we need to maintain for backcompat, so there's no point currently until we have a composefs-native store there. In contrast composefs representation in this project is AFAIK still subject to change, so let's make some changes.

@cgwalters cgwalters added the area/composefs composefs related changes label Sep 11, 2024
@rhatdan
Copy link
Member

rhatdan commented Sep 12, 2024

Makes sense to me.
@giuseppe @mtrmac @alexlarsson thoughts?

@giuseppe
Copy link
Member

I think it is a good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/composefs composefs related changes
Projects
None yet
Development

No branches or pull requests

3 participants